Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rdkafka: switch to cmake, split outputs, remove static library from non-static targets, fix static build #349725

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

rdkafka: switch to cmake, split outputs, remove static library from non-static targets, fix static build #349725

wants to merge 2 commits into from
+21 −5

Conversation

jcaesar
Copy link
Contributor

@jcaesar jcaesar commented Oct 19, 2024

Things done

(refer to PR title)

As a nice side-effect, this reduces the size of .out from 12MB to 3MB.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Result of nixpkgs-review run on x86_64-linux 1

12 packages failed to build:
  • authentik
  • dvc-with-remotes
  • dvc-with-remotes.dist
  • kafka-delta-ingest
  • python311Packages.django-health-check
  • python311Packages.django-health-check.dist
  • python312Packages.django-health-check
  • python312Packages.django-health-check.dist
  • quickgui
  • quickgui.debug
  • quickgui.pubcache
  • vector
153 packages built:
  • ceph
  • ceph-client
  • ceph-csi
  • ceph.dev
  • ceph.doc
  • libceph (ceph.lib ,libceph.dev ,libceph.doc ,libceph.lib ,libceph.man)
  • ceph.man
  • collectd
  • dvc (python312Packages.dvc)
  • dvc.dist (python312Packages.dvc.dist)
  • kcat
  • libserdes
  • libserdes.dev
  • materialize
  • modern-cpp-kafka
  • ntopng
  • ocamlPackages.kafka
  • paperless-ngx
  • php81Extensions.rdkafka
  • php82Extensions.rdkafka
  • php83Extensions.rdkafka
  • php84Extensions.rdkafka
  • pretalx
  • pretalx.dist
  • pretalx.static
  • pretix
  • pretix.dist
  • python311Packages.bytewax
  • python311Packages.bytewax.dist
  • python311Packages.celery
  • python311Packages.celery-redbeat
  • python311Packages.celery-redbeat.dist
  • python311Packages.celery-singleton
  • python311Packages.celery-singleton.dist
  • python311Packages.celery.dist
  • python311Packages.confluent-kafka
  • python311Packages.confluent-kafka.dist
  • python311Packages.django-celery-beat
  • python311Packages.django-celery-beat.dist
  • python311Packages.django-celery-email
  • python311Packages.django-celery-email.dist
  • python311Packages.django-celery-results
  • python311Packages.django-celery-results.dist
  • python311Packages.django-google-analytics-app
  • python311Packages.django-google-analytics-app.dist
  • python311Packages.django-raster
  • python311Packages.django-raster.dist
  • python311Packages.djmail
  • python311Packages.djmail.dist
  • python311Packages.dvc
  • python311Packages.dvc-gdrive
  • python311Packages.dvc-gdrive.dist
  • python311Packages.dvc-hdfs
  • python311Packages.dvc-hdfs.dist
  • python311Packages.dvc-task
  • python311Packages.dvc-task.dist
  • python311Packages.dvc.dist
  • python311Packages.dvclive
  • python311Packages.dvclive.dist
  • python311Packages.flower
  • python311Packages.flower.dist
  • python311Packages.kombu
  • python311Packages.kombu.dist
  • python311Packages.mmcv
  • python311Packages.mmcv.dist
  • python311Packages.mmengine
  • python311Packages.mmengine.dist
  • python311Packages.nameko
  • python311Packages.nameko.dist
  • python311Packages.opentelemetry-instrumentation-celery
  • python311Packages.opentelemetry-instrumentation-celery.dist
  • python311Packages.streamz
  • python311Packages.streamz.dist
  • python312Packages.bytewax
  • python312Packages.bytewax.dist
  • python312Packages.celery
  • python312Packages.celery-redbeat
  • python312Packages.celery-redbeat.dist
  • python312Packages.celery-singleton
  • python312Packages.celery-singleton.dist
  • python312Packages.celery.dist
  • python312Packages.confluent-kafka
  • python312Packages.confluent-kafka.dist
  • python312Packages.django-celery-beat
  • python312Packages.django-celery-beat.dist
  • python312Packages.django-celery-email
  • python312Packages.django-celery-email.dist
  • python312Packages.django-celery-results
  • python312Packages.django-celery-results.dist
  • python312Packages.django-google-analytics-app
  • python312Packages.django-google-analytics-app.dist
  • python312Packages.django-raster
  • python312Packages.django-raster.dist
  • python312Packages.djmail
  • python312Packages.djmail.dist
  • python312Packages.dvc-gdrive
  • python312Packages.dvc-gdrive.dist
  • python312Packages.dvc-hdfs
  • python312Packages.dvc-hdfs.dist
  • python312Packages.dvc-task
  • python312Packages.dvc-task.dist
  • python312Packages.dvclive
  • python312Packages.dvclive.dist
  • python312Packages.flower
  • python312Packages.flower.dist
  • python312Packages.kombu
  • python312Packages.kombu.dist
  • python312Packages.mmcv
  • python312Packages.mmcv.dist
  • python312Packages.mmengine
  • python312Packages.mmengine.dist
  • python312Packages.nameko
  • python312Packages.nameko.dist
  • python312Packages.opentelemetry-instrumentation-celery
  • python312Packages.opentelemetry-instrumentation-celery.dist
  • python312Packages.streamz
  • python312Packages.streamz.dist
  • qemu_full
  • qemu_full.debug
  • qemu_full.ga
  • quickemu
  • rdkafka
  • rdkafka.dev
  • rsyslog
  • samba4Full
  • samba4Full.dev
  • samba4Full.man
  • sbclPackages.cl-rdkafka
  • sourcehut.buildsrht
  • sourcehut.buildsrht.dist
  • sourcehut.coresrht
  • sourcehut.coresrht.dist
  • sourcehut.gitsrht
  • sourcehut.gitsrht.dist
  • sourcehut.hgsrht
  • sourcehut.hgsrht.dist
  • sourcehut.hubsrht
  • sourcehut.hubsrht.dist
  • sourcehut.listssrht
  • sourcehut.listssrht.dist
  • sourcehut.mansrht
  • sourcehut.mansrht.dist
  • sourcehut.metasrht
  • sourcehut.metasrht.dist
  • sourcehut.pastesrht
  • sourcehut.pastesrht.dist
  • sourcehut.todosrht
  • sourcehut.todosrht.dist
  • syslogng
  • syslogng.man
  • weblate
  • weblate.dist
  • weblate.static

I've checked that authentik, dvc-with-remotes, kafka-delta-ingest, django-health-check, quickgui, and vector all also fail on the merge base, so I consider the failures to be benign.

Add a 👍 reaction to pull requests you find important.

tobim
tobim approved these changes Oct 19, 2024
View reviewed changes
Copy link
Contributor

@tobim tobim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built pkgsStatic.rdkafka on x86_64-linux and aarch64-darwin.

@jcaesar jcaesar mentioned this pull request Oct 20, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobim tobim tobim approved these changes

@aanderse aanderse Awaiting requested review from aanderse

@globin globin Awaiting requested review from globin

@Ma27 Ma27 Awaiting requested review from Ma27

@talyz talyz Awaiting requested review from talyz

@drupol drupol Awaiting requested review from drupol

@ditsuke ditsuke Awaiting requested review from ditsuke

@commandodev commandodev Awaiting requested review from commandodev

@piotrkwiecinski piotrkwiecinski Awaiting requested review from piotrkwiecinski

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
6.topic: php 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jcaesar @drupol @tobim @wegank