Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pylyzer: 0.0.67 -> 0.0.68 #349970

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

GaetanLepage
Copy link
Contributor

Things done

Changelog: https:/mtshiba/pylyzer/releases/tag/v0.0.68

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@GaetanLepage
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 349970


x86_64-linux

❌ 1 package failed to build:
  • pylyzer

aarch64-linux

❌ 1 package failed to build:
  • pylyzer

x86_64-darwin

❌ 1 package failed to build:
  • pylyzer

aarch64-darwin

❌ 1 package failed to build:
  • pylyzer

@GaetanLepage
Copy link
Contributor Author

Compilation fails:

error[E0005]: refutable pattern in local binding
   --> crates/py2erg/convert.rs:450:13
    |
450 |         let Ok(py_program) = locator.fold(py_program);
    |             ^^^^^^^^^^^^^^ pattern `Err(_)` not covered
    |
    = note: `let` bindings require an "irrefutable pattern", like a `struct` or an `enum` with only one variant
    = note: for more information, visit https://doc.rust-lang.org/book/ch18-02-refutability.html
    = note: the matched value is of type `Result<ModModule<SourceRange>, Infallible>`
help: you might want to use `let else` to handle the variant that isn't matched
    |
450 |         let Ok(py_program) = locator.fold(py_program) else { todo!() };
    |                                                       ++++++++++++++++

For more information about this error, try `rustc --explain E0005`.
error: could not compile `py2erg` (lib) due to 1 previous error

Maybe it needs rust 1.82.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant