Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update NodeJS version used in CI #533

Merged
merged 2 commits into from
Dec 5, 2023
Merged

update NodeJS version used in CI #533

merged 2 commits into from
Dec 5, 2023

Conversation

OmarTawfik
Copy link
Contributor

As the version we request is already deprecated:

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default

OmarTawfik
OmarTawfik commented Nov 29, 2023
View reviewed changes
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (development@6c7d5b6). Click here to learn what that means.

❗ Current head 2beedd8 differs from pull request most recent head 7df9ba1. Consider uploading reports for the commit 7df9ba1 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@              Coverage Diff               @@
##             development     #533   +/-   ##
==============================================
  Coverage               ?   53.23%           
==============================================
  Files                  ?      188           
  Lines                  ?     4824           
  Branches               ?      793           
==============================================
  Hits                   ?     2568           
  Misses                 ?     2019           
  Partials               ?      237

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@OmarTawfik OmarTawfik force-pushed the update-node branch 2 times, most recently from 7f6ffac to 776c6b3 Compare November 29, 2023 02:07
@OmarTawfik OmarTawfik changed the title update NodeJS version used in CI update NodeJS/VS Code version used in CI Nov 30, 2023
@socket-security Socket Security
Copy link

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
semver 7.3.8...7.5.4 None +0/-0 93.4 kB npm-cli-ops
@vscode/test-electron 2.1.3...2.3.8 eval +4/-11 1.01 MB vscode-bot

@OmarTawfik OmarTawfik marked this pull request as ready for review November 30, 2023 04:11
@OmarTawfik OmarTawfik changed the title update NodeJS/VS Code version used in CI update NodeJS version used in CI Dec 2, 2023
@OmarTawfik
Copy link
Contributor Author

cc @kanej for review.

kanej
kanej approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@kanej kanej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Getting rid of node 14 is a delight.

OmarTawfik
OmarTawfik commented Dec 5, 2023
View reviewed changes
.github/workflows/ci.yaml
with:
run: npm run test:e2e
env:
CODE_VERSION: ${{ matrix.version }}
VSCODEGO_BEFORE_RELEASE_TESTS: true
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also removed VSCODEGO_BEFORE_RELEASE_TESTS: true as I couldn't find any usage for it in the repo, and the only reference to it online seems like internal config used by the VSCode Go extension repository:

https:/golang/vscode-go/blob/d8333230d2cac81aeb952a4d51e2fd2b06e0a472/.github/workflows/test-long-all.yml#L56-L61

https:/golang/vscode-go/blob/d8333230d2cac81aeb952a4d51e2fd2b06e0a472/test/integration/install.test.ts#L278-L283

package.json
@@ -45,7 +45,7 @@
"@types/vscode": "^1.70",
"@typescript-eslint/eslint-plugin": "5.8.0",
"@typescript-eslint/parser": "5.8.0",
"@vscode/test-electron": "2.1.3",
"@vscode/test-electron": "2.3.8",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated test-electron as it was failing because of microsoft/vscode-test#246

@OmarTawfik OmarTawfik merged commit aac6f3a into NomicFoundation:development Dec 5, 2023
5 checks passed
@OmarTawfik OmarTawfik deleted the update-node branch December 5, 2023 11:16
@OmarTawfik OmarTawfik mentioned this pull request Dec 6, 2023
Merged
kanej pushed a commit that referenced this pull request Mar 25, 2024
@OmarTawfik @kanej
update NodeJS version used in CI (#533)
388ec27
kanej pushed a commit that referenced this pull request Apr 17, 2024
@OmarTawfik @kanej
update NodeJS version used in CI (#533)
c728acf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kanej kanej kanej approved these changes

@antico5 antico5 Awaiting requested review from antico5

Assignees
No one assigned
Labels
None yet
Projects
hardhat-vscode
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@OmarTawfik @codecov-commenter @kanej @antico5