Collect syntax kinds directly from DSL v2 and isolate parser generation logic
#991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was not meant to be tackled in the follow-up refactor but is rather a possibly a low-hanging fruit in terms of performance.
This reverts commit 645b05f.
…tor" This reverts commit 117b9487e9d882b372b4944b024b32d90f8296d7.
|
Merged
OmarTawfik
reviewed
May 30, 2024
OmarTawfik
reviewed
May 30, 2024
OmarTawfik
reviewed
May 30, 2024
OmarTawfik
reviewed
May 30, 2024
OmarTawfik
reviewed
May 30, 2024
OmarTawfik
reviewed
May 30, 2024
OmarTawfik
approved these changes
Jun 3, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 5, 2024
Part of #638 Follow-up to #991 Pretty straightforward: instead of visiting the previously built v1 definition structure, we defer to `Language::collect_breaking_changes` as the definitions overlap - the breaking changes are defined as versions in which the syntax items may be evaluated differently, which means that these are exactly the versions that will be referenced for the conditional syntax item evaluation in the parser/lexer.
OmarTawfik
pushed a commit
to OmarTawfik-forks/slang
that referenced
this pull request
Aug 4, 2024
…Foundation#1002) Part of NomicFoundation#638 Follow-up to NomicFoundation#991 Pretty straightforward: instead of visiting the previously built v1 definition structure, we defer to `Language::collect_breaking_changes` as the definitions overlap - the breaking changes are defined as versions in which the syntax items may be evaluated differently, which means that these are exactly the versions that will be referenced for the conditional syntax item evaluation in the parser/lexer. Refactor `BuiltInLabel` to avoid duplication (NomicFoundation#992) Spin off of NomicFoundation#976 Moves the `BuiltInLabel` enum from the parser generator into the language definition and remove duplication in the `kinds` template. add wit generating wit and glue stub adaptors, wit feature flag glue macros remove wit_bindgen fix wit gen paths add wit-bindgen export the kinds pub export macro for wit improve export macro world => slang fully implement glue convert query matches refactor ffi glue macros refactor wit variant rather than enum back to enum
OmarTawfik
added a commit
to OmarTawfik-forks/slang
that referenced
this pull request
Aug 5, 2024
…Foundation#1002) Part of NomicFoundation#638 Follow-up to NomicFoundation#991 Pretty straightforward: instead of visiting the previously built v1 definition structure, we defer to `Language::collect_breaking_changes` as the definitions overlap - the breaking changes are defined as versions in which the syntax items may be evaluated differently, which means that these are exactly the versions that will be referenced for the conditional syntax item evaluation in the parser/lexer. Refactor `BuiltInLabel` to avoid duplication (NomicFoundation#992) Spin off of NomicFoundation#976 Moves the `BuiltInLabel` enum from the parser generator into the language definition and remove duplication in the `kinds` template. add wit generating wit and glue stub adaptors, wit feature flag glue macros remove wit_bindgen fix wit gen paths add wit-bindgen export the kinds pub export macro for wit improve export macro world => slang fully implement glue convert query matches refactor ffi glue macros refactor wit variant rather than enum back to enum
OmarTawfik
pushed a commit
to OmarTawfik-forks/slang
that referenced
this pull request
Aug 5, 2024
…Foundation#1002) Part of NomicFoundation#638 Follow-up to NomicFoundation#991 Pretty straightforward: instead of visiting the previously built v1 definition structure, we defer to `Language::collect_breaking_changes` as the definitions overlap - the breaking changes are defined as versions in which the syntax items may be evaluated differently, which means that these are exactly the versions that will be referenced for the conditional syntax item evaluation in the parser/lexer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards #638
Mainly:
quoteing or any (old) parser codegen now in the newgenerator/src/parser/codegenmodulekinds.rs.jinja2we use a new, dedicatedKindsModelto disentangle, limiting the workarounds like removing the built-in labels only after visiting the grammarParserModel.referenced_versions(it's de factoLanguage::collect_breaking_changesbut with a caveat; I'll submit a separate PR for that since it's not 100% obvious and would change how we defineParserModel).pub(super)visibility or updated referenced issues.Now, the remaining work will be to actually revamp how we visit the resulting grammar.