Node 10 support #184
Merged
Node 10 support #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenr
added a commit
that referenced
this pull request
Aug 21, 2018
Two integration tests in simpleSecurity.test.js fails using the code in PR #184. Since we are in a hurry to release a new version of pc-nrfconnect-core, now we do not have time to investigate the root cause right now. We will investigate #184 and apply the changes after the release of pc-nrfconnect-core.
bihanssen
added a commit
that referenced
this pull request
Aug 21, 2018
…-to-failed-integration-tests Remove PR #184 due to failed integration tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to support targeting node 10, type conversion and function invocation shall be updated from obsoleted calls to follow Nan's practices.