Bug: Re-introduce the patch for syntax highlighting issues regarding C++ and F# #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please refer to transitive-bullshit/nextjs-notion-starter-kit#309 and NotionX#220 for more context.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
powersagitar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tip
Please check out transitive-bullshit/nextjs-notion-starter-kit#605 for a bandaid fix before this PR gets merged.
Description
@transitive-bullshit mentioned in #220 that this fix was introduced with the release of v6, but apparently it vanished from
master, thus the same issue still persists.This PR re-introduces the patch to address syntax highlighting issues caused by Notion-prism.js language identifier mismatch.
Please refer to transitive-bullshit/nextjs-notion-starter-kit#309 and #220 for more context.
Notion Test Page ID
Before:
After:
https://powerium.notion.site/Decoding-Conditionals-A-Dive-into-if-else-switch-case-Lookup-Tables-and-Interfaces-19254846bcb64aac9c340e81518a9dac