-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NuGet.Core & NuGet.Clients License.txt clarification #7629
Comments
Thanks for filing this @devlead If you run "build.ps1" you should be able to avoid this. It's something that we plan on doing before the next release. We need to rework our build scripts a bit before doing that, because right now we are a bit too machine dependent (we use the pack.targets on the build machine). On our CI we use machines that normally contain the latest versions of VS but considering one shipped a day or two ago, it's possible that not all of them have been updated yet, leading to potential build failures. tl;dr; Can you please revise the text of https:/NuGet/NuGet.Client/blob/dev/LICENSE.txt? |
@nkolev92 Ok, I'll try to fork and take a look at this tomorrow. |
@devlead I have a PR out to move to the license expressions. The 2nd part of this issue is addressing the content of the license in our repo itself, so the PR won't auto close it. |
Excellent 👍 |
Assigning to @karann-msft and @anangaur Can you please help clarifying the below concern? Also noted assembly meta data says copyright Microsoft <Copyright>© Microsoft Corporation. All rights reserved.</Copyright> whereas the license linked to in nupkg's says
This might be in order, but if not I could correct that to in the PR. |
The client packages now use license expressions. @anangaur @karann-msft Please help addressing the other concern raised in this issue. |
@devlead - this should resolve the main ask for the packages we publish going forward. Feel free to close the issue if that is the case :)
For existing published packages, I don't believe it is kosher to change the license from a legal standpoint which is why we now have self-contained licenses which make them immutable :)
Microsoft owns the license to the NuGet package and its contents - hence the assembly metadata says Microsoft copyright. The package and the DLLs are also signed by the Microsoft cert. However, the license governing the source code is the one at the root of the individual repo. |
Ok, I see. Then I'll go ahead and close this issue. |
Details about Problem
NuGet product used: NuGet.Core & NuGet.Clients projects ( https:/NuGet/NuGet.Client/ )
NuGet version; 4.9.2
dotnet.exe --version (if appropriate): v2.1.6 SDK 2.1.500
Currently when compiling the NuGet.Core & NuGet.Clients projects you get an error because projects use
licenseUrl
element which as of a couple of weeks back with the 4.9.x release is deprecated.- error NU5125: The 'licenseUrl' element will be deprecated. Consider using the 'license' element instead.
Currently the used settings are ( https:/NuGet/NuGet.Client/blob/87f433bbf1240aaa42d91d2d5955767a857a4699/build/config.props#L46 )
https://aka.ms/nugetlicense redirects to https://raw.githubusercontent.com/NuGet/NuGet.Client/dev/LICENSE.txt which at least at this moment means you get https://raw.githubusercontent.com/NuGet/NuGet.Client/87f433bbf1240aaa42d91d2d5955767a857a4699/LICENSE.txt, but that could be subject to change in the future.
New recommendation is to use Self-Contained NuGet Packages - License using new
PackageLicenseExpression
/license
orPackageLicenseFile
element. For NuGet this would mean for csprojand nuspec
according to NuGet License expressions & embedded licenses technical design.
I would happily propose a PR to address this.
A quick search resulted in these files
Also noted assembly meta data says copyright Microsoft
whereas the license linked to in nupkg's says
This might be in order, but if not I could correct that to in the PR.
The text was updated successfully, but these errors were encountered: