[15.0][MIG]-Account_move_line_purchase_info #1274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently translated at 100,0% (5 of 5 strings) Translation: account-financial-tools-11.0/account-financial-tools-11.0-account_move_line_purchase_info Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-11-0/account-financial-tools-11-0-account_move_line_purchase_info/de/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-financial-tools-12.0/account-financial-tools-12.0-account_move_line_purchase_info Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-12-0/account-financial-tools-12-0-account_move_line_purchase_info/
Currently translated at 100.0% (5 of 5 strings) Translation: account-financial-tools-12.0/account-financial-tools-12.0-account_move_line_purchase_info Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-12-0/account-financial-tools-12-0-account_move_line_purchase_info/pt_BR/
To force wheel regeneration, because the currently published wheel wrongly depends on odoo12-addon-purchase_stock which is a standard Odoo module.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-financial-tools-12.0/account-financial-tools-12.0-account_move_line_purchase_info Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-12-0/account-financial-tools-12-0-account_move_line_purchase_info/
Currently translated at 100.0% (5 of 5 strings) Translation: account-financial-tools-12.0/account-financial-tools-12.0-account_move_line_purchase_info Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-12-0/account-financial-tools-12-0-account_move_line_purchase_info/pt/
Currently translated at 100.0% (6 of 6 strings) Translation: account-financial-tools-12.0/account-financial-tools-12.0-account_move_line_purchase_info Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-12-0/account-financial-tools-12-0-account_move_line_purchase_info/pt_BR/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-financial-tools-13.0/account-financial-tools-13.0-account_move_line_purchase_info Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-13-0/account-financial-tools-13-0-account_move_line_purchase_info/
…ensure invoice count consistency
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-financial-tools-13.0/account-financial-tools-13.0-account_move_line_purchase_info Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-13-0/account-financial-tools-13-0-account_move_line_purchase_info/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-financial-tools-13.0/account-financial-tools-13.0-account_move_line_purchase_info Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-13-0/account-financial-tools-13-0-account_move_line_purchase_info/
BernatPForgeFlow
approved these changes
Nov 24, 2021
|
|
||
|
|
||
| class TestAccountMoveLinePurchaseInfo(common.TransactionCase): | ||
| def setUp(self): |
| from odoo import api, models | ||
|
|
||
|
|
||
| class PurchaseOrder(models.Model): |
There was a problem hiding this comment.
I'd move this to a separate purchase_order.py file
| """Overwritten compute to avoid show all Journal Entries with | ||
| purchase_order_line as invoice_lines One2many would take them into account.""" | ||
| for order in self: | ||
| invoices = order.mapped("order_line.invoice_lines.move_id").filtered( |
There was a problem hiding this comment.
Suggested change
| invoices = order.mapped("order_line.invoice_lines.move_id").filtered( | |
| invoices = order.order_line.invoice_lines.move_id.filtered( |
mapping is not necessary here, anyway not blocking
| invoices = order.mapped("order_line.invoice_lines.move_id").filtered( | ||
| lambda m: m.is_invoice(include_receipts=True) | ||
| ) | ||
| order.invoice_ids = [(6, 0, invoices.ids)] |
There was a problem hiding this comment.
Suggested change
| order.invoice_ids = [(6, 0, invoices.ids)] | |
| order.invoice_ids = invoices |
same but looks better :P
There was a problem hiding this comment.
@ivantodorovich Thanks for the review! Solved :)
JoanMForgeFlow
force-pushed
the
15.0-mig-account_move_line_purchase_info
branch
from
2f2c032
to
18c50d3
Compare
ivantodorovich
approved these changes
Nov 26, 2021
AaronHForgeFlow
requested changes
Nov 26, 2021
| @@ -5,7 +5,7 @@ | |||
| { | |||
| "name": "Account Move Line Purchase Info", | |||
| "summary": "Introduces the purchase order line to the journal items", | |||
| "version": "14.0.1.0.1", | |||
| "version": "15.0.1.0.1", | |||
JoanMForgeFlow
force-pushed
the
15.0-mig-account_move_line_purchase_info
branch
from
18c50d3
to
d51c304
Compare
JoanMForgeFlow
changed the title
AaronHForgeFlow
approved these changes
Nov 29, 2021
|
/ocabot migration account_move_line_purchase_info /ocabot merge nobump |
|
/ocabot merge nobump |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 8787358. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standard migration to version 15: module Account move line purchase info