[15.0][MIG] account_menu: migrate module from 14.0 to 15.0 #1275

AlvaroTForgeFlow · 2021-11-24T11:18:08Z

No description provided.

AlvaroTForgeFlow · 2021-12-01T10:16:10Z

ChrisOForgeFlow

Please let us evaluate the feasibility of renaming, since the module has several additional features to only the menus.

ChrisOForgeFlow · 2021-12-02T16:55:20Z

account_menu/readme/ROADMAP.rst

@@ -0,0 +1,2 @@
+* Suggest to rename to something like `account_usability` in 15.0, given that


I also agree with this recommendation

Understood. I don't think a renaming is needed since menus are still the main functionality, right?

Okay, they are the menu feature, however the module has more features than the menu, so the name change could give more sense to the rest of the added features, what do you think?

I see your point. I'll make sure to make those changes asap.

@ChrisOForgeFlow It should be good now.

ChrisOForgeFlow

+1

HaraldPanten

Functional review

HaraldPanten

Please, check pre-commit

AlvaroTForgeFlow · 2021-12-10T14:06:04Z

Oddly enough, I tried to re-run it in local and the pre-commit passed succesfully.

GuillemCForgeFlow · 2022-03-14T09:04:37Z

@HaraldPanten It seems like the runboat is failing because of this error when building:
× python setup.py egg_info did not run successfully. │ exit code: 1 ╰─> [1 lines of output] error in vatnumber setup command: use_2to3 is invalid. [end of output]
I've seen other PR's of this repo which seem to have the same error. Any idea on how should we fix this?

HaraldPanten · 2022-03-14T09:43:46Z

Hhhhmmm... maybe @sbidoul or @pedrobaeza could shed some light here.

sbidoul · 2022-03-14T10:47:08Z

@GuillemCForgeFlow @HaraldPanten the problem here is that base_vat_optional_vies depends on vatnumber, which is unmaintained and incompatible with the latest setuptools.

Odoo itself has removed the dependency on vatnumber. I think we should do the same, as we don't want to pin an old setuptools version in the oca/oca-ci image just for this.

rafaelbn · 2022-03-23T23:55:51Z

/ocabot migration account_menu

rafaelbn · 2022-03-24T00:01:05Z

We have the same problem about vatnumber in #1360

rafaelbn · 2022-04-04T11:21:05Z

/ocabot rebase

OCA-git-bot · 2022-04-04T11:21:15Z

@rafaelbn The rebase process failed, because command git push --force ForgeFlow tmp-pr-1275:15.0-mig-account_menu failed with output:

remote: Permission to ForgeFlow/account-financial-tools.git denied to OCA-git-bot.
fatal: unable to access 'https:/ForgeFlow/account-financial-tools/': The requested URL returned error: 403

[UPD] Update account_menu.pot

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-financial-tools-14.0/account-financial-tools-14.0-account_menu Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-14-0/account-financial-tools-14-0-account_menu/

Currently translated at 100.0% (26 of 26 strings) Translation: account-financial-tools-14.0/account-financial-tools-14.0-account_menu Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-14-0/account-financial-tools-14-0-account_menu/pt/

…o account_usability

rafaelbn · 2022-04-04T11:26:11Z

Hello @HaraldPanten , please could you re-review? 😄 this is ready!

rafaelbn · 2022-04-04T11:26:57Z

@AaronHForgeFlow please could you review this PR from @ForgeFlow ? thanks!

rafaelbn · 2022-04-04T11:29:39Z

Solved

Solved :+1

OCA-git-bot · 2022-04-04T11:30:31Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

rafaelbn · 2022-04-04T11:30:35Z

/ocabot merge nobump

OCA-git-bot · 2022-04-04T11:30:46Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-1275-by-rafaelbn-bump-nobump, awaiting test results.

HaraldPanten

LGTM

OCA-git-bot · 2022-04-04T11:38:08Z

Congratulations, your PR was merged at 401acae. Thanks a lot for contributing to OCA. ❤️

Ref : OCA/account-financial-tools#1275

ChrisOForgeFlow suggested changes Dec 2, 2021

View reviewed changes

ChrisOForgeFlow approved these changes Dec 7, 2021

View reviewed changes

etobella approved these changes Dec 7, 2021

View reviewed changes

OCA-git-bot added the approved label Dec 7, 2021

HaraldPanten approved these changes Dec 7, 2021

View reviewed changes

HaraldPanten previously requested changes Dec 7, 2021

View reviewed changes

OCA-git-bot removed the approved label Dec 7, 2021

AlvaroTForgeFlow force-pushed the 15.0-mig-account_menu branch from 94e9cce to d1c6a4a Compare December 9, 2021 08:53

AlvaroTForgeFlow requested a review from HaraldPanten December 10, 2021 14:05

GuillemCForgeFlow force-pushed the 15.0-mig-account_menu branch 2 times, most recently from 11c714e to 98759a0 Compare March 14, 2022 08:50

rafaelbn mentioned this pull request Mar 23, 2022

[15.0][MIG] account_menu #1303

Closed

OCA-git-bot added this to the 15.0 milestone Mar 23, 2022

OCA-git-bot mentioned this pull request Mar 23, 2022

Migration to version 15.0 #1253

Open

31 tasks

legalsylvain and others added 7 commits April 4, 2022 13:23

[ADD] account_menu cortesy @arthru

64d9776

[UPD] README.rst

854fdd4

[UPD] Update account_menu.pot

[ADD] bank statements menu entries

3e46fe4

[UPD] README.rst

a8cccc3

[UPD] Update account_menu.pot

[MIG] account_menu: Migration to 13.0

bd76821

[UPD] Update account_menu.pot

6294359

[UPD] README.rst

4ce9209

oca-travis and others added 9 commits April 4, 2022 13:23

[UPD] Update account_menu.pot

432f2a2

[UPD] README.rst

8450650

account_menu 14.0.1.1.0

e45c903

[REF] adopting account_menu

f6a8162

[UPD] README.rst

263c150

[15.0][MIG]account_menu: black, isort, prettier

9e13b2c

[15.0][MIG]account_usability: Module name changed from account_menu t…

96f937f

…o account_usability

GuillemCForgeFlow force-pushed the 15.0-mig-account_menu branch from 98759a0 to 96f937f Compare April 4, 2022 11:23

OCA-git-bot added the approved label Apr 4, 2022

rafaelbn approved these changes Apr 4, 2022

View reviewed changes

OCA-git-bot added the ready to merge label Apr 4, 2022

OCA-git-bot added the bot is merging ⏳ label Apr 4, 2022

HaraldPanten approved these changes Apr 4, 2022

View reviewed changes

OCA-git-bot merged commit cdf14f4 into OCA:15.0 Apr 4, 2022

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Apr 4, 2022

JuanyDForgeflow mentioned this pull request Jun 28, 2022

[15.0][MIG] account_asset_management_menu #1435

Merged

legalsylvain added a commit to OCA/OpenUpgrade that referenced this pull request Oct 17, 2022

[ADD] rename account_menu into account_usability

227f66e

Ref : OCA/account-financial-tools#1275

legalsylvain mentioned this pull request Oct 17, 2022

[ADD] rename account_menu into account_usability OCA/OpenUpgrade#3590

Merged

legalsylvain mentioned this pull request Aug 6, 2024

[16.0][ADD] product_usability OCA/product-attribute#1657

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[15.0][MIG] account_menu: migrate module from 14.0 to 15.0 #1275

[15.0][MIG] account_menu: migrate module from 14.0 to 15.0 #1275

AlvaroTForgeFlow commented Nov 24, 2021

AlvaroTForgeFlow commented Dec 1, 2021

ChrisOForgeFlow left a comment

ChrisOForgeFlow Dec 2, 2021

AlvaroTForgeFlow Dec 3, 2021 •

edited

Loading

ChrisOForgeFlow Dec 3, 2021

AlvaroTForgeFlow Dec 7, 2021

AlvaroTForgeFlow Dec 7, 2021

ChrisOForgeFlow left a comment

HaraldPanten left a comment

HaraldPanten left a comment

AlvaroTForgeFlow commented Dec 10, 2021

GuillemCForgeFlow commented Mar 14, 2022

HaraldPanten commented Mar 14, 2022

sbidoul commented Mar 14, 2022

rafaelbn commented Mar 23, 2022

rafaelbn commented Mar 24, 2022

rafaelbn commented Apr 4, 2022

OCA-git-bot commented Apr 4, 2022

rafaelbn commented Apr 4, 2022

rafaelbn commented Apr 4, 2022

rafaelbn commented Apr 4, 2022

OCA-git-bot commented Apr 4, 2022

rafaelbn commented Apr 4, 2022

OCA-git-bot commented Apr 4, 2022

HaraldPanten left a comment

OCA-git-bot commented Apr 4, 2022

		@@ -0,0 +1,2 @@
		* Suggest to rename to something like `account_usability` in 15.0, given that

[15.0][MIG] account_menu: migrate module from 14.0 to 15.0 #1275

[15.0][MIG] account_menu: migrate module from 14.0 to 15.0 #1275

Conversation

AlvaroTForgeFlow commented Nov 24, 2021

AlvaroTForgeFlow commented Dec 1, 2021

ChrisOForgeFlow left a comment

Choose a reason for hiding this comment

ChrisOForgeFlow Dec 2, 2021

Choose a reason for hiding this comment

AlvaroTForgeFlow Dec 3, 2021 • edited Loading

Choose a reason for hiding this comment

ChrisOForgeFlow Dec 3, 2021

Choose a reason for hiding this comment

AlvaroTForgeFlow Dec 7, 2021

Choose a reason for hiding this comment

AlvaroTForgeFlow Dec 7, 2021

Choose a reason for hiding this comment

ChrisOForgeFlow left a comment

Choose a reason for hiding this comment

HaraldPanten left a comment

Choose a reason for hiding this comment

HaraldPanten left a comment

Choose a reason for hiding this comment

AlvaroTForgeFlow commented Dec 10, 2021

GuillemCForgeFlow commented Mar 14, 2022

HaraldPanten commented Mar 14, 2022

sbidoul commented Mar 14, 2022

rafaelbn commented Mar 23, 2022

rafaelbn commented Mar 24, 2022

rafaelbn commented Apr 4, 2022

OCA-git-bot commented Apr 4, 2022

rafaelbn commented Apr 4, 2022

rafaelbn commented Apr 4, 2022

rafaelbn commented Apr 4, 2022

OCA-git-bot commented Apr 4, 2022

rafaelbn commented Apr 4, 2022

OCA-git-bot commented Apr 4, 2022

HaraldPanten left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Apr 4, 2022

AlvaroTForgeFlow Dec 3, 2021 •

edited

Loading