Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0] [MIG] account_move_line_tax_editable #1368

Closed

Conversation

JSeguiN97
Copy link

No description provided.

benwillig and others added 20 commits March 29, 2022 11:12
OCA Transbot updated translations from Transifex

OCA Transbot updated translations from Transifex
[UPD] Update account_move_line_tax_editable.pot
Currently translated at 100,0% (2 of 2 strings)

Translation: account-financial-tools-11.0/account-financial-tools-11.0-account_move_line_tax_editable
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-11-0/account-financial-tools-11-0-account_move_line_tax_editable/de/
Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-financial-tools-12.0/account-financial-tools-12.0-account_move_line_tax_editable
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-12-0/account-financial-tools-12-0-account_move_line_tax_editable/
* [FIX] Do not hide Originator Tax
* [IMP] Add optional hide option to Originator Tax
* [FIX] Drop tax_ids field from Journal Item page, as it is already displayed.
@JSeguiN97 JSeguiN97 mentioned this pull request Mar 31, 2022
31 tasks
@AaronHForgeFlow
Copy link
Contributor

Could you include this? dbb4061 from this PR? #1352

/ocabot migration account_move_line_tax_editable

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Mar 31, 2022
@rafaelbn
Copy link
Member

rafaelbn commented Apr 4, 2022

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

@rafaelbn The rebase process failed, because command git push --force QubiQ tmp-pr-1368:15.0-mig-account_move_line_tax_editable failed with output:

remote: Permission to QubiQ/account-financial-tools.git denied to OCA-git-bot.
fatal: unable to access 'https:/QubiQ/account-financial-tools/': The requested URL returned error: 403

@rafaelbn
Copy link
Member

rafaelbn commented Apr 4, 2022

Hello @JSeguiN97 , please could you please attend #1368 (comment) ? Thanks!

@JSeguiN97 JSeguiN97 force-pushed the 15.0-mig-account_move_line_tax_editable branch from f5e1548 to f9e1e70 Compare April 6, 2022 07:21
@oca-clabot
Copy link

Hey @JSeguiN97, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: https://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

@JSeguiN97 JSeguiN97 force-pushed the 15.0-mig-account_move_line_tax_editable branch from f9e1e70 to 59682a9 Compare April 6, 2022 07:24
@HaraldPanten
Copy link
Contributor

HaraldPanten commented Apr 29, 2022

@manuelregidor @ValentinVinagre could you review?

@HaraldPanten
Copy link
Contributor

@sbidoul Do you know why is runboat failing here?

THX!

@sbidoul
Copy link
Member

sbidoul commented May 2, 2022

@HaraldPanten that's the good old vatnumber that is unmaintained. We need to get rid of it (I thought that was done, BTW, as we discussed that elsewhere in this repo, see for instance #1360 (comment))

@HaraldPanten
Copy link
Contributor

@HaraldPanten that's the good old vatnumber that is unmaintained. We need to get rid of it (I thought that was done, BTW, as we discussed that elsewhere in this repo, see for instance #1360 (comment))

Yep, I thought we did before 🤔. Let's see...

@HaraldPanten
Copy link
Contributor

Hey @JSeguiN97, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet. You can read and sign our full Contributor License Agreement here: https://odoo-community.org/page/cla Here is a list of the users:

Appreciation of efforts, OCA CLAbot

By the way... @JSeguiN97 did you sign the OCA CLA?

THX

@rafaelbn
Copy link
Member

rafaelbn commented May 3, 2022

/ocabot rebase

Note: moduon@7df0b27

@OCA-git-bot
Copy link
Contributor

@rafaelbn The rebase process failed, because command git push --force QubiQ tmp-pr-1368:15.0-mig-account_move_line_tax_editable failed with output:

remote: Permission to QubiQ/account-financial-tools.git denied to OCA-git-bot.
fatal: unable to access 'https:/QubiQ/account-financial-tools/': The requested URL returned error: 403

@ValentinVinagre

This comment was marked as off-topic.

@rafaelbn
Copy link
Member

rafaelbn commented May 3, 2022

OK, so @JSeguiN97 , can you answer about this PR please? If no answer after 29 days of the first question [JSeg ](#1368 (comment)) I think any one can open a new PR and this one will be closed. thank you! 😄 🙏

@etobella
Copy link
Member

etobella commented May 3, 2022

I think you can open a new PR and close this.

@rafaelbn
Copy link
Member

rafaelbn commented May 4, 2022

Closing then

@rafaelbn rafaelbn closed this May 4, 2022
@HaraldPanten
Copy link
Contributor

Once this PR is merged --> #1352 , our team is going to supersede this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.