Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][MIG] website_sale_secondary_unit: Migration to 15.0 #652

Merged
merged 16 commits into from
Oct 1, 2022
Merged

[15.0][MIG] website_sale_secondary_unit: Migration to 15.0 #652

merged 16 commits into from
Oct 1, 2022

Conversation

CarlosRoca13
Copy link
Contributor

@CarlosRoca13 CarlosRoca13 commented May 30, 2022 •
edited by pedrobaeza
Loading

@CarlosRoca13 CarlosRoca13 force-pushed the 15.0-MIG-website_sale_secondary_unit branch from 718c90a to 27d5531 Compare May 30, 2022 07:29
@CarlosRoca13 CarlosRoca13 force-pushed the 15.0-MIG-website_sale_secondary_unit branch from 27d5531 to 2d32f3a Compare August 9, 2022 11:04
@sergio-teruel
Copy link

@CarlosRoca13 Review cart

In V13
Selección_1373

In V15 is not correct
Selección_1374

@CarlosRoca13 CarlosRoca13 force-pushed the 15.0-MIG-website_sale_secondary_unit branch from 2d32f3a to 4f9842a Compare August 16, 2022 09:05
@CarlosRoca13
Copy link
Contributor Author

@sergio-teruel solved! Now in v15 we have to override the function _submitForm of publicWidget.registry.WebsiteSale to add the new fields added on products Form.

@CarlosRoca13 CarlosRoca13 force-pushed the 15.0-MIG-website_sale_secondary_unit branch 2 times, most recently from 645429c to 262a366 Compare August 16, 2022 10:04
sergio-teruel
sergio-teruel approved these changes Aug 19, 2022
View reviewed changes
Copy link

@sergio-teruel sergio-teruel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do a rebase, the PR OCA/sale-workflow#2057 has been merged

sergio-teruel and others added 16 commits August 19, 2022 08:08
@sergio-teruel @CarlosRoca13
[11.0][ADD] website_sale_secondary_unit: New module
28be3dd
@sergio-teruel @CarlosRoca13
[11.0][FIX] website_sale_secondary_unit: Crash if product_uom not com…
7ffc44e 
…e in values
@sergio-teruel @CarlosRoca13
[11.0][FIX] website_sale_secondary_unit: Fix tour tests
6632db9
@sergio-teruel @CarlosRoca13
[11.0][IMP] website_sale_secondary_unit: Display product uom after pr…
406e5f0 
…ice when product has secondary units defined
@sergio-teruel @CarlosRoca13
[MIG] website_sale_secondary_unit: Migration to v12.0
bd4812f
@sergio-teruel @CarlosRoca13
[FIX] website_sale_secondary_unit: Fix quantity position in cart lines
ec6b1f6
@sergio-teruel @CarlosRoca13
[IMP] website_sale_secondary_unit: Set default secondary uom for prod…
018566e 
…ucts when "Add to cart" view is enabled.
@AndreVolksdorf @CarlosRoca13
Added translation using Weblate (German)
7c3f756
@CarlosRoca13
[IMP] website_sale_secondary_unit: black, isort, prettier
fc9d787
@CarlosRoca13
[MIG] website_sale_secondary_unit: Migration to v13.0
c1eb0d5
@pedrobaeza @CarlosRoca13
[FIX] website_sale_secondary_unit: Adjust to upstream changes
144f5ba 
As the product.secondary.unit view has been isolated, we have to
inherit from that one.
@sergio-teruel @CarlosRoca13
[FIX] website_sale_secondary_unit: Remove sudo access to avoid to dis…
452a0ab 
…play unpublished secondary units.

TT31018
@celm1990 @CarlosRoca13
FIX: script for delete view before update
a5e2423 
complementary to OCA@3fa2331
@CarlosRoca13
[FIX] website_sale_secondary_unit: Fixed price computation
761e030 
Before this changes, the change in the value of the secondary unit input field
didn't launch the execution of the onchanges of the real input field.

Adding this changes, we achieve to capture the event of the new input field
to launch the onchanges of the real input field.

cc @Tecnativa TT29708
@CarlosRoca13
[IMP] website_sale_secondary_unit: black, isort, prettier
1ac8da5
@CarlosRoca13
[MIG] website_sale_secondary_unit: Migration to 15.0
d61b1ff
@CarlosRoca13 CarlosRoca13 force-pushed the 15.0-MIG-website_sale_secondary_unit branch from 262a366 to d61b1ff Compare August 19, 2022 06:09
@dreispt
Copy link
Sponsor Member

dreispt commented Oct 1, 2022

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 15.0-ocabot-merge-pr-652-by-dreispt-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Oct 1, 2022
@OCA-git-bot
Merge PR #652 into 15.0
eb22676 
Signed-off-by dreispt
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 15.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 15.0-ocabot-merge-pr-652-by-dreispt-bump-nobump, awaiting test results.

@pedrobaeza
Copy link
Member

/ocabot migration website_sale_secondary_unit

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Oct 1, 2022
@OCA-git-bot OCA-git-bot mentioned this pull request Oct 1, 2022
Closed
41 tasks
@OCA-git-bot OCA-git-bot merged commit 29a9dc8 into OCA:15.0 Oct 1, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 7c54843. Thanks a lot for contributing to OCA. ❤️

pilarvargas-tecnativa pushed a commit to Tecnativa/e-commerce that referenced this pull request Jan 24, 2023
@OCA-git-bot
Merge PR OCA#652 into 15.0
f664c8c 
Signed-off-by dreispt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergio-teruel sergio-teruel sergio-teruel approved these changes

@carlosdauden carlosdauden carlosdauden approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.
8 participants
@CarlosRoca13 @sergio-teruel @dreispt @OCA-git-bot @pedrobaeza @carlosdauden @AndreVolksdorf @celm1990