[17.0][MIG] website_sale_product_attribute_value_filter_existing: Migration to 17.0 #925
Conversation
lef-adhoc
force-pushed
the
17.0-mig-website_sale_product_attribute_value_filter_existing
branch
4 times, most recently
from
d5e2cfd
to
4f5f7cd
Compare
lef-adhoc
force-pushed
the
17.0-mig-website_sale_product_attribute_value_filter_existing
branch
2 times, most recently
from
ba27c27
to
846fa13
Compare
lef-adhoc
force-pushed
the
17.0-mig-website_sale_product_attribute_value_filter_existing
branch
from
846fa13
to
5e39b07
Compare
|
@pilarvargas-tecnativa Hi, may you check this? |
|
thanks! @chienandalu can you take a look? |
|
@chienandalu Hi, do you have any news about this? |
|
LGTM, functionally tested. |
|
@lef-adhoc please check pre-commit |
|
Apologies, I have given a positive review, however, it seems that there is a caching issue that we had missed. One of our team is investigating to see if they can assist :) |
|
@theangryangel Any luck with resolving caching issue ? Can You share in details what kind of problem did You find? |
|
We ended up needing to go a different direction to meet the customer's need, and I don't think we've come back to look at this. @GarethGloSystems can you remind me what we ran into? |
… to 15.0 [UPD] Update website_sale_product_attribute_value_filter_existing.pot
…nature match the function signature of shop with the original one from website_sale, to avoid potential issues with other modules overwriting the function and passing unexpected parameters
…to check the real functionality of the module TT45590
…ormance improvement - Switch to setUpClass for avoiding repeat the same setup for each test. - Include context keys for avoiding mail operations overhead.
…er extraction in mobile view
lef-adhoc
force-pushed
the
17.0-mig-website_sale_product_attribute_value_filter_existing
branch
from
5e39b07
to
90c4906
Compare
|
@pilarvargas-tecnativa pre-commit is ready |
|
This PR has the |
|
odoo/odoo@29b6b85 added The last time I investigated these changes were incompatible with this module. |
|
AFAIK, you can remove that cache or expand it with the needed data using the inheritance system (with |
lef-adhoc
force-pushed
the
17.0-mig-website_sale_product_attribute_value_filter_existing
branch
from
90c4906
to
ed4cfe0
Compare
|
@pilarvargas-tecnativa hi, can you check if everything is ok? |
@lef-adhoc Hi, but I see you have included the change in your migration commit, you should cherry-pick the commit with the fix to keep the history. |
…ibute parent container If only the attribute container is hidden, the parent container still occupies a space that is visible in the attribute list. To avoid this, apply the condition to the parent container and hide it completely. TT50704
lef-adhoc
force-pushed
the
17.0-mig-website_sale_product_attribute_value_filter_existing
branch
from
ed4cfe0
to
603718b
Compare
lef-adhoc
force-pushed
the
17.0-mig-website_sale_product_attribute_value_filter_existing
branch
from
603718b
to
6e11f1d
Compare
No description provided.