Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] fieldservice_account_analytic: automatically fill Contact in FSM Order #1219

Open
wants to merge 1 commit into
base: 14.0
Choose a base branch
from
Open

[FIX] fieldservice_account_analytic: automatically fill Contact in FSM Order #1219

wants to merge 1 commit into from

Conversation

tafaRU
Copy link
Member

@tafaRU tafaRU commented Oct 3, 2024 •
edited
Loading

Start by saying that the logical behind it is not clear to me, during a debug session I noticed the following problem.

To Reproduce

Steps to reproduce the behavior:

  1. create a FSM order
  2. set location_id field
  3. edit the FSM order and save it

Expected behavior
Contact is automatically filled with that one of the Location.

Additional context
In debug we have:

> "customer_id" not in vals and order.customer_id is False
> False

> "customer_id" not in vals and not order.customer_id
> True

@tafaRU
[FIX] fieldservice_account_analytic: automatically fill Contact in FS…
27b562b 
…M Order

When customer_id is not set in the order we have:

> "customer_id" not in vals and order.customer_id is False
> False

> "customer_id" not in vals and not order.customer_id
> True
@OCA-git-bot
Copy link
Contributor

Hi @osimallen, @brian10048, @bodedra,
some modules you are maintaining are being modified, check this out!

@tafaRU
Copy link
Member Author

tafaRU commented Oct 3, 2024 •
edited
Loading

Tests are failing due to https:/OCA/field-service/blob/cf1f50e498036043ac08c41ed3ac803fdef1f446/fieldservice_stock_account/models/fsm_order.py#L52 is no longer raised.
@OCA/field-service-maintainers is it reasonable to fix them by removing assertRaises here?

@max3903 max3903 added this to the 14.0 milestone Oct 8, 2024
@max3903
Copy link
Sponsor Member

max3903 commented Oct 10, 2024

@OCA/field-service-maintainers is it reasonable to fix them by removing assertRaises here?

👍

@max3903 max3903 self-assigned this Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max3903 max3903 max3903 approved these changes

@hparfr hparfr hparfr approved these changes

Assignees

@max3903 max3903

Labels
approved bug needs review
Projects
None yet
Milestone
14.0
Development

Successfully merging this pull request may close these issues.
4 participants
@tafaRU @OCA-git-bot @max3903 @hparfr