Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADD] module price_multicompany #1

Closed
wants to merge 7 commits into from
Closed

[ADD] module price_multicompany #1

wants to merge 7 commits into from

Conversation

bealdav
Copy link
Member

@bealdav bealdav commented Sep 16, 2014

No description provided.

rvalyi
rvalyi reviewed Sep 17, 2014
View reviewed changes
sale_check_multicompany/__openerp__.py
'category': '',
'sequence': 10,
'description': """
Check if datas in quotation are linked to the same company
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

data is already plural -> no 's' (singular is datum)

@pedrobaeza
Copy link
Member

I think there are some overlaps here. We have some alternatives for this that we have to clean:

@bealdav
Copy link
Member Author

bealdav commented Oct 18, 2014

sale_check_multicompany might be in a better place in OCA/sale-workflow.
@pedrobaeza it concerns sale, not product
What do you think ?

@pedrobaeza
Copy link
Member

Well, this module covers multi-company, so it can fit here, and the models covered (res.currency, product.price.type, etc) are very general (not only for sale).

The other topic that I raised concerned me more about overlappings. The third module I didn't remember was product_price_history in margin-analysis repo (https:/OCA/margin-analysis/tree/7.0/product_price_history).

@bealdav
Copy link
Member Author

bealdav commented Oct 21, 2014

Hi @pedrobaeza
I have renamed my module. Now, the use case is more precise, i think you'll understand there no overlaps. Feature in my module should be use without features of the modules you mentionned

Thanks

guewen
guewen reviewed Oct 21, 2014
View reviewed changes
sale_check_multicompany/sale.py
for elm in self.browse(cr, uid, ids):
if elm.pricelist_id:
if isinstance(elm.company_id, orm.browse_null) \
or not elm.company_id:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you check if the type is orm.browse_null?
browse_null.__nonzero__ always returns False so elm.company_id will be Falsy if it is a browse_null.

@guewen
Copy link
Member

guewen commented Oct 21, 2014

What do you mean by

I have renamed my module. Now, the use case is more precise, i think you'll understand there no overlaps. Feature in my module should be use without features of the modules you mentionned

? It is incompatible with the aforementioned modules?

@bealdav
Copy link
Member Author

bealdav commented Oct 21, 2014

@guewen thanks for your really interesting inline comments.
Sorry for my bad english i would like say: Feature in my module CAN be use without features of the modules you mentionned

@pedrobaeza
Copy link
Member

OK, I understand now the purpose of the module, but there are two modules in this PR. Please split them in separate PRs.

This was referenced Dec 30, 2014
Merged
Closed
@bealdav
Copy link
Member Author

bealdav commented Dec 30, 2014

replaced by #4 and #5

@bealdav bealdav closed this Dec 30, 2014
lmignon added a commit to acsone/multi-company that referenced this pull request May 10, 2017
@lmignon @lasley
10.0 base multi company lmi (OCA#1)
71ec1a5 
* Revert "Revert hook view create back to model init"

This reverts commit 770bd71.

* [FIX] base_multi_company: Always create the view into a pre_init_hook to avoid error in log
pedrobaeza pushed a commit that referenced this pull request May 18, 2017
@lmignon @lasley
10.0 base multi company lmi (#1)
2c9777e 
* Revert "Revert hook view create back to model init"

This reverts commit 770bd71.

* [FIX] base_multi_company: Always create the view into a pre_init_hook to avoid error in log
rodrigets referenced this pull request in multidadosti-erp/multi-company Jul 31, 2018
@lmignon @rodrigets
10.0 base multi company lmi (#1)
5b52c4b 
* Revert "Revert hook view create back to model init"

This reverts commit 770bd71.

* [FIX] base_multi_company: Always create the view into a pre_init_hook to avoid error in log
mstuttgart referenced this pull request in multidadosti-erp/multi-company Aug 6, 2018
@lmignon @mstuttgart
10.0 base multi company lmi (#1)
426fa09 
* Revert "Revert hook view create back to model init"

This reverts commit 770bd71.

* [FIX] base_multi_company: Always create the view into a pre_init_hook to avoid error in log
OCA-git-bot pushed a commit that referenced this pull request Sep 20, 2019
@lmignon @florian-dacosta
10.0 base multi company lmi (#1)
91ce90f 
* Revert "Revert hook view create back to model init"

This reverts commit 770bd71.

* [FIX] base_multi_company: Always create the view into a pre_init_hook to avoid error in log
max3903 referenced this pull request in ursais/multi-company Jan 16, 2020
@Khalid-SerpentCS
Merge pull request #1 from ursais/12.0-ADD-account_move_multi_company
f0f6ede 
[FIX] account_move_multi_company
JoanSForgeFlow pushed a commit to ForgeFlow/multi-company that referenced this pull request Mar 25, 2020
@lmignon @JoanSForgeFlow
10.0 base multi company lmi (OCA#1)
29aa22d 
* Revert "Revert hook view create back to model init"

This reverts commit 770bd71.

* [FIX] base_multi_company: Always create the view into a pre_init_hook to avoid error in log
JoanSForgeFlow pushed a commit to ForgeFlow/multi-company that referenced this pull request Mar 27, 2020
@lmignon @JoanSForgeFlow
10.0 base multi company lmi (OCA#1)
7657ed2 
* Revert "Revert hook view create back to model init"

This reverts commit 770bd71.

* [FIX] base_multi_company: Always create the view into a pre_init_hook to avoid error in log
rousseldenis pushed a commit to acsone/multi-company that referenced this pull request Mar 9, 2021
@lmignon @rousseldenis
10.0 base multi company lmi (OCA#1)
415cb32 
* Revert "Revert hook view create back to model init"

This reverts commit 770bd71.

* [FIX] base_multi_company: Always create the view into a pre_init_hook to avoid error in log
james-willdooit pushed a commit to WilldooIT/multi-company that referenced this pull request Oct 4, 2021
@lmignon @james-willdooit
10.0 base multi company lmi (OCA#1)
f50810e 
* Revert "Revert hook view create back to model init"

This reverts commit 770bd71.

* [FIX] base_multi_company: Always create the view into a pre_init_hook to avoid error in log
xavier-bouquiaux pushed a commit to acsone/multi-company that referenced this pull request Oct 25, 2021
@lmignon @xavier-bouquiaux
10.0 base multi company lmi (OCA#1)
248b05f 
* Revert "Revert hook view create back to model init"

This reverts commit 770bd71.

* [FIX] base_multi_company: Always create the view into a pre_init_hook to avoid error in log
JasminSForgeFlow pushed a commit to ForgeFlow/multi-company that referenced this pull request Feb 21, 2022
@lmignon @JasminSForgeFlow
10.0 base multi company lmi (OCA#1)
f5ae9a2 
* Revert "Revert hook view create back to model init"

This reverts commit 770bd71.

* [FIX] base_multi_company: Always create the view into a pre_init_hook to avoid error in log
JasminSForgeFlow pushed a commit to ForgeFlow/multi-company that referenced this pull request Mar 14, 2022
@lmignon @JasminSForgeFlow
10.0 base multi company lmi (OCA#1)
437f231 
* Revert "Revert hook view create back to model init"

This reverts commit 770bd71.

* [FIX] base_multi_company: Always create the view into a pre_init_hook to avoid error in log
JasminSForgeFlow pushed a commit to ForgeFlow/multi-company that referenced this pull request Mar 30, 2022
@lmignon @JasminSForgeFlow
10.0 base multi company lmi (OCA#1)
b22113f 
* Revert "Revert hook view create back to model init"

This reverts commit 770bd71.

* [FIX] base_multi_company: Always create the view into a pre_init_hook to avoid error in log
JasminSForgeFlow pushed a commit to ForgeFlow/multi-company that referenced this pull request Mar 31, 2022
@lmignon @JasminSForgeFlow
10.0 base multi company lmi (OCA#1)
58ac94d 
* Revert "Revert hook view create back to model init"

This reverts commit 770bd71.

* [FIX] base_multi_company: Always create the view into a pre_init_hook to avoid error in log
OCA-git-bot pushed a commit that referenced this pull request Jan 26, 2023
@ajaniszewska-dev
Merge pull request #1 from leemannd/stock_intercompany
6a30d0d 
14.0 Fix stock_picking: use the source partner for the new created pi…
SodexisTeam referenced this pull request in sodexis/multi-company Mar 13, 2023
@lmignon
10.0 base multi company lmi (#1)
c98d9e4 
* Revert "Revert hook view create back to model init"

This reverts commit 770bd71.

* [FIX] base_multi_company: Always create the view into a pre_init_hook to avoid error in log
rven pushed a commit to DynAppsNV/multi-company that referenced this pull request May 21, 2024
@lmignon @rven
10.0 base multi company lmi (OCA#1)
1e424a8 
* Revert "Revert hook view create back to model init"

This reverts commit 770bd71.

* [FIX] base_multi_company: Always create the view into a pre_init_hook to avoid error in log
rven pushed a commit to DynAppsNV/multi-company that referenced this pull request May 21, 2024
@lmignon @rven
10.0 base multi company lmi (OCA#1)
0fa187b 
* Revert "Revert hook view create back to model init"

This reverts commit 770bd71.

* [FIX] base_multi_company: Always create the view into a pre_init_hook to avoid error in log
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bealdav @pedrobaeza @guewen @rvalyi