Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0] [mig] pos_require_product_quantity #633

Merged
merged 21 commits into from
May 8, 2021

Conversation

fshah-initos
Copy link
Contributor

No description provided.

robinkeunen and others added 21 commits April 28, 2021 16:36
Currently translated at 100.0% (5 of 5 strings)

Translation: pos-12.0/pos-12.0-pos_require_product_quantity
Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_require_product_quantity/es/
…ctionpadWidget, causing issues with other modules
This 'good practice' improves compatibility with other modules.
This improves readability
Also, avoid setting the click event handler if the option is disabled in pos.config
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: pos-12.0/pos-12.0-pos_require_product_quantity
Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_require_product_quantity/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: pos-12.0/pos-12.0-pos_require_product_quantity
Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_require_product_quantity/
@chienandalu chienandalu mentioned this pull request Apr 29, 2021
16 tasks
@chienandalu chienandalu added this to the 14.0 milestone Apr 29, 2021
Copy link
Contributor

@dsolanki-initos dsolanki-initos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Functional test and code review.

@fshah-initos
Copy link
Contributor Author

It would be great if we could get the reviews and merge the PR.

@dreispt
Copy link
Sponsor Member

dreispt commented May 8, 2021

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-633-by-dreispt-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 0b48a9d into OCA:14.0 May 8, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at ff1b954. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.