[14.0] [mig] pos_reset_search #651
Conversation
|
It would be great if we get the reviews here |
|
@flotho It would be great if you could add the reviews |
|
It would be great if we could get the reviews here |
2 similar comments
|
It would be great if we could get the reviews here |
|
It would be great if we could get the reviews here |
|
Hi @Fkawala It would be nice if you can review this PR |
|
@dsolanki-initos sure will do that ASAP (probably tomorrow) |
|
Hi @ivantodorovich It would be nice if you can review the PR |
| @@ -1,12 +1,39 @@ | |||
| odoo.define("product_click_search_reset", function (require) { | |||
There was a problem hiding this comment.
| odoo.define("product_click_search_reset", function (require) { | |
| odoo.define("pos_reset_search.ProductScreen", function (require) { |
Also rename file to ProductScreen.js please
There was a problem hiding this comment.
This one's still pending :)
We can merge after this is AFAICS
There was a problem hiding this comment.
This one's still pending @dsolanki-initos
| const ProductsWidgetControlPanel = _.find( | ||
| ProductWidgetChildrens, | ||
| function (children) { | ||
| if (children.el.className === "products-widget-control") { | ||
| return children; | ||
| } | ||
| } | ||
| ); |
There was a problem hiding this comment.
| const ProductsWidgetControlPanel = _.find( | |
| ProductWidgetChildrens, | |
| function (children) { | |
| if (children.el.className === "products-widget-control") { | |
| return children; | |
| } | |
| } | |
| ); | |
| const ProductsWidgetControlPanel = ProductWidgetChildren.find( | |
| child => child.el.className === "products-widget-control" | |
| ); |
Also "children" is already plural (of "child"), so you can remove the "s"
Please note there are other occurrences like this one
| const ProductWidget = _.find(ProductScreenChildrens, function ( | ||
| children | ||
| ) { | ||
| if (children.el.className === "products-widget") { | ||
| return children; | ||
| } | ||
| }); |
There was a problem hiding this comment.
| const ProductWidget = _.find(ProductScreenChildrens, function ( | |
| children | |
| ) { | |
| if (children.el.className === "products-widget") { | |
| return children; | |
| } | |
| }); | |
| const ProductWidget = ProductScreenChildren.find( | |
| child => child.el.className === "products-widget" | |
| ); |
| const PosProductScreen = (ProductScreen) => | ||
| class extends ProductScreen { | ||
| async _clickProduct(event) { | ||
| const ProductScreenChildrens = this.__owl__.children; |
There was a problem hiding this comment.
I'm not so familiar with owl yet to know if this is ok, but I trust you here :)
| - Le Nid | ||
| - CoopITEasy | ||
|
|
||
| * Dhara Solanki <[email protected]> |
There was a problem hiding this comment.
| - Le Nid | |
| - CoopITEasy | |
| * Dhara Solanki <[email protected]> | |
| * Le Nid | |
| * CoopITEasy | |
| * Dhara Solanki <[email protected]> |
Would you please normalize this too?
dsolanki-initos
force-pushed
the
14.0-mig-pos_reset_search
branch
3 times, most recently
from
0aab88c
to
f497aa4
Compare
|
Hello, @ivantodorovich Changes are done can you please re-review it? |
hkapatel-initos
force-pushed
the
14.0-mig-pos_reset_search
branch
from
f497aa4
to
c3b01ca
Compare
|
Hello, @ivantodorovich Changes are done can you please re-review it? |
|
/ocabot merge nobump |
|
On my way to merge this fine PR! |
|
Hi, @ivantodorovich can we try to merge this again? |
|
/ocabot merge nobump |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 61edc0a. Thanks a lot for contributing to OCA. ❤️ |
No description provided.