[MIG] sales_team_security: Migration to 15.0

sales_team_security/__manifest__.py

@@ -4,16 +4,19 @@
 {
  "name": "Sales documents permissions by channels (teams)",
  "summary": "New group for seeing only sales channel's documents",
- "version": "14.0.2.0.0",
+ "version": "15.0.1.0.0",
  "category": "Sales",
  "website": "https:/OCA/sale-workflow",
  "author": "Tecnativa, Odoo Community Association (OCA)",
  "license": "AGPL-3",
  "installable": True,
  "development_status": "Production/Stable",
  "maintainers": ["pedrobaeza", "ivantodorovich"],
- "depends": ["sales_team"],
- "data": ["security/sales_team_security.xml", "views/res_partner_view.xml"],
+ "depends": ["sales_team", "sale", "crm"],
+ "data": [
+ "security/sales_team_security.xml",
+ "views/res_partner_view.xml",
+ ],
  "post_init_hook": "post_init_hook",
  "uninstall_hook": "uninstall_hook",
 }

sales_team_security/models/ir_rule.py

@@ -55,4 +55,85 @@ def _compute_domain(self, model_name, mode="read"):
  ]
  extra_domain = expression.normalize_domain(extra_domain)
  res = expression.AND([extra_domain] + [res])
+ if model_name == "sale.order" and not self.env.su:
+ if user.has_group(group2):
+ extra_domain = [
+ "|",
+ "|",
+ ("user_id", "=", user.id),
+ ("user_id", "=", False),
+ "|",
+ ("team_id", "=", user.sale_team_id.id),
+ ("team_id", "=", False),
+ ]
+
+ extra_domain = expression.normalize_domain(extra_domain)
+ res = expression.AND([extra_domain] + [res])
+
+ if model_name == "sale.report" and not self.env.su:
+ if user.has_group(group2):
+ extra_domain = [
+ "|",
+ "|",
+ ("user_id", "=", user.id),
+ ("user_id", "=", False),
+ "|",
+ ("team_id", "=", user.sale_team_id.id),
+ ("team_id", "=", False),
+ ]
+
+ extra_domain = expression.normalize_domain(extra_domain)
+ res = expression.AND([extra_domain] + [res])
+
+ if model_name == "sale.order.line" and not self.env.su:
+ if user.has_group(group2):
+ extra_domain = [
+ "|",
+ "|",
+ ("salesman_id", "=", user.id),
+ ("salesman_id", "=", False),
+ "|",
+ ("order_id.team_id", "=", user.sale_team_id.id),
+ ("order_id.team_id", "=", False),
+ ]
+
+ extra_domain = expression.normalize_domain(extra_domain)
+ res = expression.AND([extra_domain] + [res])
+
+ if model_name == "crm.lead" and not self.env.su:
+ if user.has_group(group2):
+ extra_domain = [
+ "|",
+ "|",
+ ("user_id", "=", user.id),
+ ("user_id", "=", False),
+ "|",
+ ("team_id", "=", user.sale_team_id.id),
+ ("team_id", "=", False),
+ ]
+
+ extra_domain = expression.normalize_domain(extra_domain)
+ res = expression.AND([extra_domain] + [res])
+
+ if model_name == "crm.activity.report" and not self.env.su:
+ if user.has_group(group2):
+ extra_domain = [
+ "|",
+ "|",
+ ("user_id", "=", user.id),
+ ("user_id", "=", False),
+ "|",
+ ("team_id", "=", user.sale_team_id.id),
+ ("team_id", "=", False),
+ ]
+
+ extra_domain = expression.normalize_domain(extra_domain)
+ res = expression.AND([extra_domain] + [res])
+ if model_name == "crm.team" and not self.env.su:
+ if user.has_group(group1):
+ extra_domain = [("id", "=", user.sale_team_id.id)]
+
+ extra_domain = expression.normalize_domain(extra_domain)
+ res = expression.AND([extra_domain] + [res])
+
  return res

sales_team_security/readme/CONTRIBUTORS.rst

@@ -2,6 +2,7 @@
 
  * Pedro M. Baeza
  * Víctor Martínez
+ * César A. Sánchez
 
 * `Guadaltech <https://www.guadaltech.es>`__:
 

sales_team_security/security/sales_team_security.xml

@@ -5,7 +5,8 @@
  <field name="name">User: Team Documents Only</field>
  <field
  name="comment"
- >The user will have an access to the documents of the sales teams he/she belongs to.</field>
+ >The user will have an access to the documents of the sales teams he/she belongs to.
+ </field>
  <field name="category_id" ref="base.module_category_sales_sales" />
  <field name="implied_ids" eval="[(4, ref('sales_team.group_sale_salesman'))]" />
  </record>
@@ -14,4 +15,5 @@
  <field name="implied_ids" eval="[(6, 0, [ref('group_sale_team_manager')])]" />
  </record>
 
+
 </odoo>

sales_team_security/tests/common.py

@@ -9,8 +9,25 @@ class TestCommon(common.SavepointCase):
  @classmethod
  def setUpClass(cls):
  super().setUpClass()
- cls.team = cls.env.ref("sales_team.team_sales_department")
- cls.team2 = cls.env.ref("sales_team.crm_team_1")
+
+ cls.team = cls.env["crm.team"].create({"name": "Test channel"})
+ cls.team2 = cls.env["crm.team"].create({"name": "Test channel 2"})
+
+ cls.user = cls.env["res.users"].create(
+ {
+ "login": "sales_team_security",
+ "name": "Test sales_team_security user",
+ "groups_id": [(4, cls.env.ref("sales_team.group_sale_salesman").id)],
+ }
+ )
+
+ cls.crm_team_member = cls.env["crm.team.member"].create(
+ {
+ "user_id": cls.user.id,
+ "crm_team_id": cls.team.id,
+ }
+ )
+
  cls.partner = cls.env["res.partner"].create(
  {"name": "Test partner", "team_id": cls.team.id}
  )
@@ -20,22 +37,20 @@ def setUpClass(cls):
  cls.partner_child_2 = cls.env["res.partner"].create(
  {"name": "Child 2", "parent_id": cls.partner.id, "type": "invoice"}
  )
- cls.user = cls.env["res.users"].create(
- {
- "login": "sales_team_security",
- "name": "Test sales_team_security user",
- "groups_id": [(4, cls.env.ref("sales_team.group_sale_salesman").id)],
- "sale_team_id": cls.team.id,
- }
- )
  cls.user2 = cls.env["res.users"].create(
  {
  "login": "sales_team_security2",
  "name": "Test sales_team_security user 2",
  "groups_id": [(4, cls.env.ref("sales_team.group_sale_salesman").id)],
- "sale_team_id": cls.team.id,
  }
  )
+ cls.crm_team_member2 = cls.env["crm.team.member"].create(
+ {
+ "user_id": cls.user2.id,
+ "crm_team_id": cls.team.id,
+ }
+ )
+
  cls.check_permission_subscribe = False
 
  def _check_permission(self, salesman, team, expected):