Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][MIG] sale_validity: Migration to 14.0 #1314

Merged
merged 30 commits into from
Nov 24, 2020

Conversation

newtratip
Copy link
Member

@newtratip newtratip commented Nov 3, 2020

Edited Readme and res_config_settings.xml

Ready for review.

jbaudoux and others added 28 commits November 3, 2020 19:19
Add POT file
Add default value duration (in days) for validity per company (ignored if you leave the value to 0, which is the default).
Convert YAML tests to unittests
Add README.rst
Currently translated at 100.0% (8 of 8 strings)

Translation: sale-workflow-12.0/sale-workflow-12.0-sale_validity
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_validity/zh_CN/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-12.0/sale-workflow-12.0-sale_validity
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_validity/
Currently translated at 100.0% (10 of 10 strings)

Translation: sale-workflow-12.0/sale-workflow-12.0-sale_validity
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_validity/zh_CN/
Currently translated at 100.0% (10 of 10 strings)

Translation: sale-workflow-13.0/sale-workflow-13.0-sale_validity
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-sale_validity/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-13.0/sale-workflow-13.0-sale_validity
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-sale_validity/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-13.0/sale-workflow-13.0-sale_validity
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-sale_validity/
Currently translated at 100.0% (9 of 9 strings)

Translation: sale-workflow-13.0/sale-workflow-13.0-sale_validity
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-sale_validity/es/
@newtratip newtratip mentioned this pull request Nov 3, 2020
87 tasks
@newtratip newtratip changed the title [MIG] sale_validity: Migration to 14.0 [14.0][MIG] sale_validity: Migration to 14.0 Nov 4, 2020
Copy link
Sponsor

@tonygalmiche tonygalmiche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM : Functional review only with runbot

image

Copy link
Member

@bodedra bodedra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review 👍

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@rousseldenis
Copy link
Sponsor Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-1314-by-rousseldenis-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 24, 2020
Signed-off-by rousseldenis
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 14.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 14.0-ocabot-merge-pr-1314-by-rousseldenis-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit d5a29da into OCA:14.0 Nov 24, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 2e392a8. Thanks a lot for contributing to OCA. ❤️

norlinhenrik pushed a commit to loymcom/sale-workflow that referenced this pull request Sep 20, 2023
Signed-off-by bguillot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.