Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG] sale_wishlist: Migration to 14.0 #1401

Merged
merged 13 commits into from
Apr 8, 2021
Merged

[MIG] sale_wishlist: Migration to 14.0 #1401

merged 13 commits into from
Apr 8, 2021

Conversation

phuctranfxvn
Copy link
Contributor

Requires module:

@phuctranfxvn phuctranfxvn mentioned this pull request Dec 29, 2020
Open
87 tasks
petrus-v
petrus-v approved these changes Jan 27, 2021
View reviewed changes
Copy link

@petrus-v petrus-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me by reading code source

@rousseldenis rousseldenis added this to the 14.0 milestone Jan 27, 2021
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@rousseldenis
Copy link
Sponsor Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-1401-by-rousseldenis-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jan 28, 2021
@OCA-git-bot
Merge PR #1401 into 14.0
8339a4e 
Signed-off-by rousseldenis
@OCA-git-bot
Copy link
Contributor

@rousseldenis your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-1401-by-rousseldenis-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

bguillot
bguillot reviewed Mar 26, 2021
View reviewed changes
test-requirements.txt Outdated
@@ -0,0 +1 @@
odoo14-addon-sale-product-set @ git+https:/trobz/[email protected]_product_set#subdirectory=setup/sale_product_set
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @phuctranerp

Can you remove this line since the dependency has been merged ?

Thanks !

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done thanks

simahawk and others added 13 commits April 8, 2021 17:12
@rousseldenis
Copy link
Sponsor Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-1401-by-rousseldenis-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 55a6a7c into OCA:14.0 Apr 8, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 0203b91. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bguillot bguillot bguillot left review comments

@petrus-v petrus-v petrus-v approved these changes

@rousseldenis rousseldenis rousseldenis approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 migration needs review ready to merge
Projects
None yet
Milestone
14.0
Development

Successfully merging this pull request may close these issues.
8 participants
@phuctranfxvn @OCA-git-bot @rousseldenis @bguillot @petrus-v @simahawk @oca-travis @danimv5