[14.0][MIG] sale_order_line_date #1460

cor9003 · 2021-02-10T19:15:57Z

Standard migration and adapt testing to codecov range

[FIX] Update readme to latest template

Currently translated at 100.0% (3 of 3 strings) Translation: sale-workflow-11.0/sale-workflow-11.0-sale_order_line_date Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-11-0/sale-workflow-11-0-sale_order_line_date/de/

Co-Authored-By: mpanarin <[email protected]>

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-12.0/sale-workflow-12.0-sale_order_line_date Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_order_line_date/

Currently translated at 100.0% (3 of 3 strings) Translation: sale-workflow-12.0/sale-workflow-12.0-sale_order_line_date Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_order_line_date/pt_BR/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-13.0/sale-workflow-13.0-sale_order_line_date Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-sale_order_line_date/

Currently translated at 100.0% (4 of 4 strings) Translation: sale-workflow-13.0/sale-workflow-13.0-sale_order_line_date Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-sale_order_line_date/es/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-13.0/sale-workflow-13.0-sale_order_line_date Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-sale_order_line_date/

allowing users to hide the column from the tree

Currently translated at 75.0% (3 of 4 strings) Translation: sale-workflow-13.0/sale-workflow-13.0-sale_order_line_date Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-sale_order_line_date/nl_NL/

cor9003 · 2021-02-10T20:23:28Z

Hi, all green. Do I have to do any step for review ?. Thanks

cor9003 · 2021-02-17T14:10:11Z

Hi, The objective of this module is not split stock pickings based in different dates, only to inform dates in every stock move and also in sale order line and commintmet date. The module sale_deilvery_split_date is in charge of that changing the procurement, but before migrated the sale_deilvery_split_date is necessary migrate it because one depends of other By the way I' found and error in my previuos commit has been solved now in the date of stock move :-) Thanks DMPyme <http://www.dmpyme.com> David Martinez Garcia / Consultor [email protected] <mailto:[email protected]> DMPyme 93 676 34 18 Ext - 101 C/ Major 26 Sant Climent de Llobregat, Barcelona www.dmpyme.com <http://www.dmpyme.com> El 17/2/21 a las 1:38, NetFX Tech escribió:

…

Hi cor, will you please confirm your stock pickings are generating correctly? I'm still only receiving one delivery order image <https://user-images.githubusercontent.com/62037189/108139607-4bcad280-7075-11eb-9178-af6551026fc5.png> — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1460 (comment)>, or unsubscribe <https:/notifications/unsubscribe-auth/ABREYZX6P55CRX6MW2OIHWDS7MFXNANCNFSM4XNQRKVA>.

danimv5

Functional review. LGTM!!

CasVissers-360ERP · 2021-03-11T07:47:58Z

sale_order_line_date/models/sale_order_line.py

- if res.order_id.commitment_date and not res.commitment_date:
- res.write({"commitment_date": res.order_id.commitment_date})
- return res
-


@cor9003 Why did you remove this method?

Hello, we were done several testing and this code never had this casuistic res.order_id.commitment_date and not res.commitment_date, for this reason never should be executed.
Checked the test data in the module we saw that never pass through this code neither and codecov also confirmed it.

CasVissers-360ERP

Code review question

OCA-git-bot · 2021-03-11T08:12:23Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

rousseldenis · 2021-03-30T11:06:56Z

@cor9003 Is this ready ?

cor9003 · 2021-03-30T11:10:02Z

@rousseldenis Yes, ready. Do i have any additional thing before merge ?

rousseldenis · 2021-03-30T11:11:29Z

@rousseldenis Yes, ready. Do i have any additional thing before merge ?

Nope, just to check if last commit is significant by its own or needs to be squashed.

cor9003 · 2021-03-30T11:14:49Z

@rousseldenis Yes, ready. Do i have any additional thing before merge ?

Nope, just to check if last commit is significant by its own or needs to be squashed.

From my point of view es Ok

rousseldenis · 2021-03-31T08:43:56Z

/ocabot merge patch

OCA-git-bot · 2021-03-31T08:44:09Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-1460-by-rousseldenis-bump-patch, awaiting test results.

OCA-git-bot · 2021-03-31T08:53:59Z

Congratulations, your PR was merged at d772cc0. Thanks a lot for contributing to OCA. ❤️

AaronHForgeFlow and others added 30 commits February 10, 2021 15:40

Update code

94db88d

[FIX] Update readme to latest template

sale_order_line_date v9

8281f66

OCA Transbot updated translations from Transifex

70fc172

[MIG] sale_order_line_date v10

605ab99

OCA Transbot updated translations from Transifex

2b7fd00

[MIG] sale_order_line_date: Migration to 11.0

c1d0b68

[FIX] Function name to prepare procurement values

9a482c7

[UPD] Update sale_order_line_date.pot

08bfc29

[ADD] icon.png

041e41b

Translated using Weblate (German)

7d5bdd3

Currently translated at 100.0% (3 of 3 strings) Translation: sale-workflow-11.0/sale-workflow-11.0-sale_order_line_date Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-11-0/sale-workflow-11-0-sale_order_line_date/de/

[MIG] sale_order_line_date: Migration to 12.0

ab0fb15

[MIG] 12.0 sale_order_line_date

86b1e45

[IMP] Add segurity group in views

019c85c

Co-Authored-By: mpanarin <[email protected]>

[UPD] Readme

642ede5

[FIX] Final touches of migration to v12

0845db0

[UPD] Update sale_order_line_date.pot

eff5c32

[UPD] README.rst

5ba526a

[IMP] sale_order_line_date: black, isort

1bf5233

[13.0][MIG] sale_order_line_date

5fd4660

[UPD] Update sale_order_line_date.pot

acebd21

[UPD] README.rst

8fea0c1

pre-commit update

40ef084

Translated using Weblate (Spanish)

a0d3a13

Currently translated at 100.0% (4 of 4 strings) Translation: sale-workflow-13.0/sale-workflow-13.0-sale_order_line_date Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-sale_order_line_date/es/

[UPD] Eficent -> ForgeFlow

0dd67f0

[IMP] sale_order_line_date: improving commitment_date tree column

41444ce

allowing users to hide the column from the tree

sale_order_line_date 13.0.1.1.0

0e09e39

Cas Vissers and others added 3 commits February 10, 2021 15:40

Translated using Weblate (Dutch)

833a016

Currently translated at 75.0% (3 of 4 strings) Translation: sale-workflow-13.0/sale-workflow-13.0-sale_order_line_date Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-sale_order_line_date/nl_NL/

[IMP] sale_order_line_date: black, isort, prettier

b833f5e

[MIG] sale_order_line_date: Migration to 14.0

7000b87

cor9003 mentioned this pull request Feb 10, 2021

Migration to version 14.0 #1274

Open

87 tasks

[FIX] chane date_expeted from V13 to date_deadline V14

f9e751a

danimv5 approved these changes Feb 26, 2021

View reviewed changes

CasVissers-360ERP reviewed Mar 11, 2021

View reviewed changes

CasVissers-360ERP approved these changes Mar 11, 2021

View reviewed changes

OCA-git-bot added the approved label Mar 11, 2021

OCA-git-bot added the ready to merge label Mar 11, 2021

rousseldenis added this to the 14.0 milestone Mar 30, 2021

rousseldenis approved these changes Mar 31, 2021

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label Mar 31, 2021

OCA-git-bot merged commit 7da68cd into OCA:14.0 Mar 31, 2021

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Mar 31, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[14.0][MIG] sale_order_line_date #1460

[14.0][MIG] sale_order_line_date #1460

cor9003 commented Feb 10, 2021

cor9003 commented Feb 10, 2021

cor9003 commented Feb 17, 2021 via email

danimv5 left a comment

CasVissers-360ERP Mar 11, 2021

cor9003 Mar 11, 2021

CasVissers-360ERP left a comment

OCA-git-bot commented Mar 11, 2021

rousseldenis commented Mar 30, 2021

cor9003 commented Mar 30, 2021

rousseldenis commented Mar 30, 2021

cor9003 commented Mar 30, 2021

rousseldenis commented Mar 31, 2021

OCA-git-bot commented Mar 31, 2021

OCA-git-bot commented Mar 31, 2021

[14.0][MIG] sale_order_line_date #1460

[14.0][MIG] sale_order_line_date #1460

Conversation

cor9003 commented Feb 10, 2021

cor9003 commented Feb 10, 2021

cor9003 commented Feb 17, 2021 via email

danimv5 left a comment

Choose a reason for hiding this comment

CasVissers-360ERP Mar 11, 2021

Choose a reason for hiding this comment

cor9003 Mar 11, 2021

Choose a reason for hiding this comment

CasVissers-360ERP left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Mar 11, 2021

rousseldenis commented Mar 30, 2021

cor9003 commented Mar 30, 2021

rousseldenis commented Mar 30, 2021

cor9003 commented Mar 30, 2021

rousseldenis commented Mar 31, 2021

OCA-git-bot commented Mar 31, 2021

OCA-git-bot commented Mar 31, 2021