[14.0][MIG] sale exception #1571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rule should only count available stock from selected warehouse from sale order. Without warehouse in context, it currently sums all stock available in all warehouses.
The previous parent menu has an action attached, and with these modules, it can't be clicked.
* [FIX] sale_exception confirm wizard * [FIX] add test of test_all_draft_orders & flake8 & readme.rst * [FIX] improve codecov test * [FIX] delete odl translation * [FIX] add Camptocamp to author * [FIX] readme.rst
Raise SingletonError when you have a recordset with multiple sale order. This restore the capability to write on multiple sale.order
Currently, it's located at the root menu because. It's a migration bug because the old menu was removed from 11.0.
The method called by 'sale_check_exception' has a side effect, it writes on 'exception.rule' + on the Many2many relation between it and sale.order(.line). When decorated by @api.constrains, any error during the method will be caught and re-raised as "ValidationError". This part of code is very prone to concurrent updates as 2 sales having the same exception will both write on the same 'exception.rule'. A concurrent update (OperationalError) is re-raised as ValidationError, and then is not retried properly. Calling the same method in create/write has the same effect than @api.constrains without shadowing the exception type. Full explanation: OCA/server-tools#1642
* [IMP] sale_exception: show menu only to Exception Rule Managers * [IMP] Reindent lines to 4 spaces * [IMP] Improve information messages that display exceptions * [REM] Remove exception_ids fields from the sale order view, because it's no longer necessary and it allowed users to accidentaly deactivate a Sale Exception Rule using the active widget. * [IMP] Rename exception_ids_formatted to exceptions_summary
Disable for now as the solution is not obvious. Partially fixes OCA#972
Other ways it provokes linter fail
TestSaleOrder was useless and making sale order tests run twice.
So we can: * display the lines with an exception in red * show the exception messages when we click on a line It's a huge usability improvement when users have dozens or hundreds of lines.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-13.0/sale-workflow-13.0-sale_exception Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-sale_exception/
atchuthan
approved these changes
May 1, 2021
jcoux
suggested changes
May 3, 2021
damdam-s
force-pushed
the
14.0-mig-sale_exception_superseed
branch
from
948f1d2
to
5e9dbcb
Compare
jcoux
approved these changes
May 3, 2021
rousseldenis
approved these changes
May 3, 2021
|
@damdam-s Could you squash ? |
damdam-s
force-pushed
the
14.0-mig-sale_exception_superseed
branch
from
5e9dbcb
to
ca85e03
Compare
|
done |
|
This PR has the |
|
/ocabot merge patch |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at c6bdce2. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
superseeds #1389
@Saran440 @atchuthan @sebastienbeau @gurneyalex