Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][MIG] sale order restrict cancel existing invoice #1581

Conversation

xavier-bouquiaux
Copy link

Hi All,

In v14, invoice.state = open became move_type = out_invoice

Kr

Xbo.

@rousseldenis

@rousseldenis
Copy link
Sponsor Contributor

rousseldenis commented May 17, 2021

Hi All,

In v14, invoice.state = open became move_type = out_invoiceo

Kr

Xbo.

@rousseldenis

@xavier-bouquiaux Not exactly.

move_type is the field to distinguish pure account moves and invoices.

state field is still there but disappeared states for payment have been replace by payment_state field.

https:/odoo/odoo/blob/14.0/addons/account/models/account_move.py#L139

https:/odoo/odoo/blob/14.0/addons/account/models/account_move.py#L225

Copy link
Sponsor Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comments

@rousseldenis rousseldenis mentioned this pull request May 17, 2021
87 tasks
@Cedric-Pigeon
Copy link

Hi All,

In v14, invoice.state = open became move_type = out_invoice

Kr

Xbo.

@rousseldenis

The check must be done on payment_state and not on move type. I just arranged.

@rousseldenis
Copy link
Sponsor Contributor

@Cedric-Pigeon @xavier-bouquiaux Could you check travis and pre-commit ?

@xavier-bouquiaux xavier-bouquiaux force-pushed the 14-sale_order_restrict_cancel_existing_invoice branch from 104074d to 9f319ef Compare October 10, 2022 12:22
@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 14, 2023
@rousseldenis rousseldenis force-pushed the 14-sale_order_restrict_cancel_existing_invoice branch from 9f319ef to 2d3a341 Compare June 13, 2023 10:57
@xavier-bouquiaux xavier-bouquiaux force-pushed the 14-sale_order_restrict_cancel_existing_invoice branch from 2d3a341 to 4294c40 Compare June 14, 2023 08:31
@github-actions github-actions bot closed this Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
migration needs review stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants