Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][MIG] sale_promotion_rule_display_discount_amount #1586

Merged

Conversation

xavier-bouquiaux
Copy link

@xavier-bouquiaux xavier-bouquiaux commented May 12, 2021

Depends on:

Remove:

  • test-requirements.txt

Copy link
Contributor

@hailangvn hailangvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for minor duplicated line, all other suggestion is optional and the code is LGTM. Thanks.

lmignon and others added 5 commits June 14, 2023 11:43
This addon allow you to display the amount of the discount applied by the sale promotion rules
fix problem on quotation creation
if the order has no order line -> no need to go further in _compute_discount_total
@xavier-bouquiaux xavier-bouquiaux force-pushed the 14-sale_promotion_rule_display_discount_amount branch from d46de3f to f791970 Compare June 14, 2023 09:44
@xavier-bouquiaux
Copy link
Author

@rousseldenis , @sebastienbeau
as we merged #1583 we could merge this ?

What do you think ?

Regards

Xbo

@rousseldenis
Copy link
Sponsor Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-1586-by-rousseldenis-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 1d2d377 into OCA:14.0 Jun 14, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at fe51622. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants