Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0] [MIG] sale_order_line_packaging_qty #1611

Conversation

estekadigital
Copy link

No description provided.

@estekadigital estekadigital changed the title 14.0 Migrated sale_order_line_packaging_qty [14.0] [MIG] sale_order_line_packaging_qty Jun 13, 2021
@estekadigital estekadigital mentioned this pull request Jun 13, 2021
87 tasks
@rousseldenis rousseldenis added this to the 14.0 milestone Jun 16, 2021

_inherit = "sale.order.line"

product_packaging_qty = fields.Integer(
Copy link
Sponsor Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be Float

Copy link
Author

@estekadigital estekadigital Jun 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion it shouldn't be float, actually there was a comment in the previous code suggesting to make it integer. As a seller if I configure packaging to sell my product I want to sell it that way, otherwise the functionality is further complicated

@simahawk
Copy link
Contributor

simahawk commented Aug 3, 2021

already in v14 https:/OCA/sale-workflow/tree/14.0/sale_order_line_packaging_qty feel to propose fixes or improvements

@simahawk simahawk closed this Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants