Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][mig] sale_invoice_policy #1762

Closed
wants to merge 30 commits into from
Closed

[14.0][mig] sale_invoice_policy #1762

wants to merge 30 commits into from

Conversation

damdam-s
Copy link
Member

@damdam-s damdam-s commented Nov 5, 2021

No description provided.

rousseldenis and others added 27 commits November 5, 2021 08:55
@rousseldenis @damdam-s
[10.0][ADD] sale_invoice_policy
a622795
@rousseldenis @damdam-s
[IMP] Add search method, secures _get_to_invoice_qty,compute_invoice_…
cf45fb4 
…status computation
@rousseldenis @damdam-s
[IMP] sale_invoice_policy: Implement inverse
9151065
@rousseldenis @damdam-s
[IMP] sale_invoice_policy: Let the availability of choosing no policy…
0e07308 
… on sale order
@rousseldenis @damdam-s
[IMP] sale_invoice_policy: Add config for default_policy and if polic…
bb463d6 
…y is required on Sale Orders
@acsonefho @damdam-s
[FIX] Fix perf issue during compute invoice status (of sale.order.line)
ff321a4
@oca-travis @damdam-s
[UPD] Update sale_invoice_policy.pot
c04d900
@OCA-git-bot @damdam-s
[ADD] icon.png
c46da11
@AaronHForgeFlow @damdam-s
[MIG]sale_invoice_policy to v12
7d88acd
@oca-travis @damdam-s
[UPD] Update sale_invoice_policy.pot
c019429
@oca-transbot @damdam-s
Update translation files
87acca4 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-12.0/sale-workflow-12.0-sale_invoice_policy
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_invoice_policy/
@georginaf @damdam-s
Added translation using Weblate (Catalan)
3cfb10d
@georginaf @damdam-s
Translated using Weblate (Catalan)
b1ee567 
Currently translated at 100.0% (17 of 17 strings)

Translation: sale-workflow-12.0/sale-workflow-12.0-sale_invoice_policy
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_invoice_policy/ca/
@oca-transbot @damdam-s
Update translation files
c5257ca 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-12.0/sale-workflow-12.0-sale_invoice_policy
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_invoice_policy/
@pedrocs-exo @damdam-s
Added translation using Weblate (Portuguese)
7ce19a4
@pedrocs-exo @damdam-s
Translated using Weblate (Portuguese)
4cc589c 
Currently translated at 100.0% (17 of 17 strings)

Translation: sale-workflow-12.0/sale-workflow-12.0-sale_invoice_policy
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_invoice_policy/pt/
@renatonlima @damdam-s
[FIX] pep8 and pylint
5edef5b
@SandieFavre @damdam-s
Translated using Weblate (French)
ca82072 
Currently translated at 70.6% (12 of 17 strings)

Translation: sale-workflow-12.0/sale-workflow-12.0-sale_invoice_policy
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_invoice_policy/fr/
@quentinDupont @damdam-s
Translated using Weblate (French)
f7dabf5 
Currently translated at 100.0% (17 of 17 strings)

Translation: sale-workflow-12.0/sale-workflow-12.0-sale_invoice_policy
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_invoice_policy/fr/
@alexeirivera87 @damdam-s
[IMP] sale_invoice_policy: black, isort, prettier
5f648ad
@alexeirivera87 @damdam-s
[MIG] sale_invoice_policy: Migration to 13.0
2d75120
@oca-travis @damdam-s
[UPD] Update sale_invoice_policy.pot
dd4e465
@OCA-git-bot @damdam-s
[UPD] README.rst
11fbedc
@OCA-git-bot @damdam-s
sale_invoice_policy 13.0.1.0.1
13ec0b7
@alan196 @damdam-s
Added translation using Weblate (Spanish (Mexico))
d6fa96d
@alan196 @damdam-s
Translated using Weblate (Spanish (Mexico))
a9182c7 
Currently translated at 100.0% (17 of 17 strings)

Translation: sale-workflow-13.0/sale-workflow-13.0-sale_invoice_policy
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-sale_invoice_policy/es_MX/
@damdam-s
[IMP] sale_invoice_policy: black, isort, prettier
749ca04
@damdam-s damdam-s force-pushed the 14.0-mig-sale_invoice_policy branch 3 times, most recently from 7a48915 to 69855de Compare November 5, 2021 09:46
i-vyshnevska
i-vyshnevska reviewed Nov 5, 2021
View reviewed changes
sale_invoice_policy/wizards/res_config.py Outdated

sale_default_invoice_policy = fields.Selection(
related="default_invoice_policy",
default_model="product.template",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is "default_model" have an effect when the field is related?

@damdam-s damdam-s force-pushed the 14.0-mig-sale_invoice_policy branch 3 times, most recently from 16e3362 to e8e4461 Compare November 8, 2021 06:24
@damdam-s
Copy link
Member Author

damdam-s commented Nov 8, 2021

override #1385 and #1679

refactor due to cache issue w/ v14. leading to module not being installable.

configuration moved from res.config.settings to ir.config_parameter

@HugOdoo
Copy link

HugOdoo commented Nov 18, 2021

Hello,

Where are we on the merging of this?

Let me know,

Thanks,
Hugo

@damdam-s
Copy link
Member Author

needs review/testing

@enriquemartin
Copy link

@damdam-s @ArcheTI-HH Have a look, I have added some improvements in addition to the migration itself #1787

@kimirondon kimirondon mentioned this pull request Jan 17, 2022
Closed
@rousseldenis
Copy link
Sponsor Contributor

/ocabot migration sale_invoice_policy

@rousseldenis rousseldenis added this to the 14.0 milestone Jan 18, 2022
@OCA-git-bot OCA-git-bot mentioned this pull request Jan 18, 2022
Open
87 tasks
@rafaelbn rafaelbn mentioned this pull request Feb 16, 2022
Closed
@rafaelbn
Copy link
Member

This PR is duplicated with #1385 which was done before. If @sebastienbeau doesn't answer we can maintain the more active 😄 Thank you !

@enriquemartin
Copy link

Hi @rafaelbn you can check my PR #1787, which has some reviews and is ready to be merged.

@rafaelbn
Copy link
Member

OMG! We have 3 PR with the same module!

🤔 Dear great contributors 😄 @damdam-s @enriquemartin make more that 1 PR per module is not optimal, before making a PR you should please look for other already done. The first PR has preference except it is abandoned. If there is a new PR with the same module and you continue in the new one, please close the old one 🙏 . In other case it's really complicated to maintain.

Please close the PR which "you" opened and you are not going to work any more

Thank you!

@rousseldenis
Copy link
Sponsor Contributor

@damdam-s You reviewed the new one, we can close this ?

@damdam-s
Copy link
Member Author

yes of course

@rafaelbn rafaelbn closed this Mar 12, 2022
@rafaelbn
Copy link
Member

@rousseldenis do you know which one is the good one?

#1787 or #1385

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@i-vyshnevska i-vyshnevska i-vyshnevska left review comments

Assignees
No one assigned
Labels
duplicate migration needs review
Projects
None yet
Milestone
14.0
Development

Successfully merging this pull request may close these issues.