Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][MIG] sale_blanket_order #1865

Merged
merged 28 commits into from
Feb 3, 2022
Merged

[14.0][MIG] sale_blanket_order #1865

merged 28 commits into from
Feb 3, 2022

Conversation

tafaRU
Copy link
Member

@tafaRU tafaRU commented Jan 13, 2022

No description provided.

andreparames and others added 26 commits January 12, 2022 17:28
@andreparames @tafaRU
[10.0][ADD] sale_blanket_orders
a89ab12
@andreparames @tafaRU
sale_blanket_order: don't copy name nor confirm state
34f79fd 
When duplicating a confirmed blanket order, the new copy shouldn't
keep the state nor the sequence number (name).
@andreparames @tafaRU
sale_blanket_order: update after review
a194fca
@andreparames @tafaRU
sale_blanket_order: Re-calculate price based on qty
cdef8bc
@andreparames @tafaRU
sale_blanket_order: make prohibition of adding new lines optional
9535d48
@rousseldenis @tafaRU
[FIX] sale_blanket_order: Ondelete cascade on blanket lines
0cb9a50
@AdriaGForgeFlow @tafaRU
[11.0][MIG] Migrate module sale_blanket_order
5b3f65b
@marylla @tafaRU
Added translation using Weblate (German)
7e9a9fc
@marylla @tafaRU
Translated using Weblate (German)
99587fe 
Currently translated at 7.3% (9 of 123 strings)

Translation: sale-workflow-11.0/sale-workflow-11.0-sale_blanket_order
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-11-0/sale-workflow-11-0-sale_blanket_order/de/
@tafaRU
[MIG] sale_blanket_order: Migration to 12.0
e7aa8c8
@tafaRU
sale_blanket_order: fix the following use case scenario.
b1e07ec 
Steps to reproduce:

* create and confirm a blanket order (BO) with (product A, qty 30) and (product B, qty 20)
* from the BO create a SO with (product A, qty 10) and (product B, qty 10)
* from the BO create a SO with (product A, qty 20) and (product B, qty 0)
* from the BO create another SO with (product B, qty 10)

Current behavior:

It raises the exception "The sale has already been completed.".

Expected behavior:

No exception is raised.
@tafaRU
sale_blanket_order: correctly display images in both README and index
2c7852e
@tafaRU
sale_blanket_order: fix my email address format in CONTRIBUTORS.rst
79487bf
@Galoperd @tafaRU
Added translation using Weblate (Spanish)
262f176
@Galoperd @tafaRU
Translated using Weblate (Spanish)
67c6898 
Currently translated at 100.0% (154 of 154 strings)

Translation: sale-workflow-12.0/sale-workflow-12.0-sale_blanket_order
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_blanket_order/es/
@pedrocs-exo @tafaRU
Added translation using Weblate (Portuguese)
51e4268
@AndreVolksdorf @tafaRU
Translated using Weblate (German)
d142449 
Currently translated at 7.1% (11 of 154 strings)

Translation: sale-workflow-12.0/sale-workflow-12.0-sale_blanket_order
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_blanket_order/de/
@AndreVolksdorf @tafaRU
Translated using Weblate (German)
a755eff 
Currently translated at 53.9% (83 of 154 strings)

Translation: sale-workflow-12.0/sale-workflow-12.0-sale_blanket_order
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_blanket_order/de/
@AndreVolksdorf @tafaRU
Translated using Weblate (German)
0547fbf 
Currently translated at 100.0% (154 of 154 strings)

Translation: sale-workflow-12.0/sale-workflow-12.0-sale_blanket_order
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_blanket_order/de/
@AndreVolksdorf @tafaRU
Translated using Weblate (German)
4083ed9 
Currently translated at 100.0% (154 of 154 strings)

Translation: sale-workflow-12.0/sale-workflow-12.0-sale_blanket_order
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_blanket_order/de/
@chusamo @tafaRU
[MIG]sale_blanker_order: Migration to 13.0
99992c5
@LoisRForgeFlow @tafaRU
[IMP] sale_blanket_order: use default terms and conditions.
e30a5c9 
exactly like in sales orders.
@LoisRForgeFlow @tafaRU
[FIX] sale_blanket_order: multi-company rules were not migrated prope…
e1a314c 
…rly.
@LoisRForgeFlow @tafaRU
[IMP] sale_blanket_order: analytic acc and origin
78dde3d 
* Allow to select an analitic account in the blanket order. It
  will be passed on to the SO.
* Allow to select analytic tags on blanket order lines. They will
  be passed to the SO lines.
* Source document was not being filled in SO created from a
  blanket order.
@tafaRU
[IMP] sale_blanket_order: black, isort, prettier
7ad21ef
@tafaRU
[MIG] sale_blanket_order: Migration to 14.0
c39b6cd
@tafaRU tafaRU mentioned this pull request Jan 13, 2022
Closed
@tafaRU
Copy link
Member Author

tafaRU commented Jan 13, 2022 •
edited
Loading

Travis error seems not related to this module but to sale_shipping_info_helper (ref link). I'm checking it.

@tafaRU
Copy link
Member Author

tafaRU commented Jan 13, 2022

@janikvonrotz could you please review it?

@rousseldenis
Copy link
Sponsor Contributor

/ocabot migration sale_blanket_order

@rousseldenis rousseldenis added this to the 14.0 milestone Jan 18, 2022
@OCA-git-bot OCA-git-bot mentioned this pull request Jan 18, 2022
Open
87 tasks
@jado95
Copy link

jado95 commented Jan 27, 2022

Hi @tafaRU , when i add product on sale blanket order line, the tax added is wrong. It add credit tax and not debit tax. Is only my problem?

@francesco-ooops
Copy link
Contributor

Hi @tafaRU , when i add product on sale blanket order line, the tax added is wrong. It add credit tax and not debit tax. Is only my problem?

This issue was referenced also in #1493 and #960 but I never understood why supplier tax is used

@tafaRU
Copy link
Member Author

tafaRU commented Jan 31, 2022

when i add product on sale blanket order line, the tax added is wrong. It add credit tax and not debit tax. Is only my problem?

@jado95, this behaviour should be fixed in d27bb6f Are you testing also including this latter?

francesco-ooops
francesco-ooops approved these changes Jan 31, 2022
View reviewed changes
Copy link
Contributor

@francesco-ooops francesco-ooops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on both runbot and runboat and tax displayed is sales one (correct)

fredzamoabg
fredzamoabg approved these changes Feb 3, 2022
View reviewed changes
Copy link
Contributor

@fredzamoabg fredzamoabg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jado95
Copy link

jado95 commented Feb 3, 2022

when i add product on sale blanket order line, the tax added is wrong. It add credit tax and not debit tax. Is only my problem?

@jado95, this behaviour should be fixed in d27bb6f Are you testing also including this latter?

Perfect, with that commit is ok for me

@rousseldenis
Copy link
Sponsor Contributor

@tafaRU Have you found the problem with Travis ?

@tafaRU
Copy link
Member Author

tafaRU commented Feb 3, 2022

@tafaRU Have you found the problem with Travis ?

Hi @rousseldenis! Unfortunately not yet, today I should get back to working on it.

@tafaRU
Copy link
Member Author

tafaRU commented Feb 3, 2022

@rousseldenis finally I found it (see 2da2b64) ! Could we merge now? What do you think?

@rousseldenis
Copy link
Sponsor Contributor

@rousseldenis finally I found it (see 2da2b64) ! Could we merge now? What do you think?

Seems legit

@rousseldenis
Copy link
Sponsor Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-1865-by-rousseldenis-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 66c8bdc into OCA:14.0 Feb 3, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 57e0cda. Thanks a lot for contributing to OCA. ❤️

@tafaRU tafaRU deleted the 14.0-mig-sale_blanket_order branch February 3, 2022 17:53
@francesco-ooops francesco-ooops mentioned this pull request Oct 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janikvonrotz janikvonrotz janikvonrotz approved these changes

@jado95 jado95 jado95 approved these changes

@francesco-ooops francesco-ooops francesco-ooops approved these changes

@fredzamoabg fredzamoabg fredzamoabg approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 migration needs review
Projects
None yet
Milestone
14.0
Development

Successfully merging this pull request may close these issues.