[FIX] sale_order_type: Default value check company #1894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This could pick an incorrect type for the order's company when creating as Superuser
pedrobaeza
approved these changes
Jan 31, 2022
|
Fast-tracking as obvious patch: /ocabot merge patch |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 5c4920f. Thanks a lot for contributing to OCA. ❤️ |
|
Backported to v13 in 23c5e59 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could pick an incorrect type for the order's company when creating as Superuser
Only started happening after the recent changes in #1884, I assume it's due to the
check_companyadded to the fieldAfter those changes a cron job that created sale orders in multiple companies (as superuser) would end up always picking a
sale_order_typefor the 1st company by default and would error when trying to create any order for other companiesWith this change in default it returns to picking an appropriate type