Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG] sale_restricted_qty to 14.0 #1961

Merged
merged 16 commits into from
Apr 4, 2022
Merged

[MIG] sale_restricted_qty to 14.0 #1961

merged 16 commits into from
Apr 4, 2022

Conversation

AshishHirapara
Copy link
Contributor

Migrated sale_restricted_qty to 14.0 from 12.0

mourad-ehm and others added 15 commits March 25, 2022 15:16
@mourad-ehm @AshishHirapara
[IMP] rename module sale_order_min_qty to sale_restricted_qty
1ce508d
@mourad-ehm @AshishHirapara
[FIX] Update Readme & "use_parent" value to manual_force_sale_min_qty…
0eee147 
… and manual_force_sale_max_qty (imp user UI)
@mourad-ehm @AshishHirapara
[IMP] views & fix is_qty_less_min_qty & is_qty_bigger_max_qty
f2f809b
@mourad-ehm @AshishHirapara
[IMP] add _get_sale_restricted_qty on sale to make qty overridable by…
f21b32e 
… other module & pep8
@mourad-ehm @AshishHirapara
[FIX] _compute_sale_restricted_qty
0ce36fd
@mourad-ehm @AshishHirapara
[FIX] restricted_qty UserError Message
b687b8e
@mourad-ehm @AshishHirapara
[FIX] openupgradelib requirements.txt
8bc78b8
@sebastienbeau @AshishHirapara
[REF] refactor code to make it simplier and inheritable
59d9625
@mourad-ehm @AshishHirapara
[FIX] _compute_is_qty_less bigger multiple qty
dfb1a4a
@oca-travis @AshishHirapara
[UPD] Update sale_restricted_qty.pot
b943e81
@OCA-git-bot @AshishHirapara
[UPD] README.rst
56931fb
@OCA-git-bot @AshishHirapara
sale_restricted_qty 12.0.2.0.0
92d16bd
@SicurSam @AshishHirapara
Added translation using Weblate (Italian)
bc97c9e
@SicurSam @AshishHirapara
Translated using Weblate (Italian)
9170bd6 
Currently translated at 7.4% (4 of 54 strings)

Translation: sale-workflow-12.0/sale-workflow-12.0-sale_restricted_qty
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_restricted_qty/it/
@SicurSam @AshishHirapara
Translated using Weblate (Italian)
9bb6d9d 
Currently translated at 100.0% (54 of 54 strings)

Translation: sale-workflow-12.0/sale-workflow-12.0-sale_restricted_qty
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_restricted_qty/it/
@AshishHirapara AshishHirapara force-pushed the 14.0-mig-sale_restricted_qty branch 2 times, most recently from f01155b to 10c3fcf Compare March 25, 2022 10:25
@AshishHirapara AshishHirapara mentioned this pull request Mar 25, 2022
Open
87 tasks
@AshishHirapara AshishHirapara force-pushed the 14.0-mig-sale_restricted_qty branch 2 times, most recently from 6b594b7 to 309eea5 Compare March 26, 2022 07:24
rousseldenis
rousseldenis requested changes Mar 28, 2022
View reviewed changes
Copy link
Sponsor Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add yourself to CONTRIBUTORS

@rousseldenis
Copy link
Sponsor Contributor

/ocabot migration sale_restricted_qty

@OCA-git-bot OCA-git-bot added this to the 14.0 milestone Mar 28, 2022
@elvise
Copy link

elvise commented Mar 29, 2022

@AshishHirapara @rousseldenis functional test ok!

francesco-ooops
francesco-ooops approved these changes Mar 29, 2022
View reviewed changes
Copy link
Contributor

@francesco-ooops francesco-ooops left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (functional review)

@rousseldenis is it ok now?

@AshishHirapara
Copy link
Contributor Author

Add yourself to CONTRIBUTORS

@rousseldenis done

@elvise
Copy link

elvise commented Apr 1, 2022

@rousseldenis what do you think can we merge ?

rousseldenis
rousseldenis approved these changes Apr 4, 2022
View reviewed changes
Copy link
Sponsor Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AshishHirapara For the next time, could you follow migration guide ?

https:/OCA/maintainer-tools/wiki/Migration-to-version-14.0#technical-method-to-migrate-a-module-from-130-to-140-branch

Especially the full process part in order to have a commit for sytnax fixing and then the migration commit. Thanks

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@rousseldenis
Copy link
Sponsor Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-1961-by-rousseldenis-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit f54af2c into OCA:14.0 Apr 4, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at b40d75e. Thanks a lot for contributing to OCA. ❤️

@AshishHirapara
Copy link
Contributor Author

@AshishHirapara For the next time, could you follow migration guide ?

OCA/maintainer-tools/wiki/Migration-to-version-14.0#technical-method-to-migrate-a-module-from-130-to-140-branch

Especially the full process part in order to have a commit for sytnax fixing and then the migration commit. Thanks

@rousseldenis could you guide me on what went wrong with this commit Or which part of that guide did I miss? Because I have followed all the steps mentioned in that guide, and squashed previous commits of mine. So I will be more careful next time.
Thanks

@rousseldenis
Copy link
Sponsor Contributor

image

You should have two commits, one with "[IMP] sale_restricted_qty: black, isort, prettier" that should not be squashed and then the migration one. That in order to split the changes that are really migration

@alexey-pelykh
Copy link

@rousseldenis did you see that there's duplication in views for product variants?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elvise elvise elvise approved these changes

@rousseldenis rousseldenis rousseldenis approved these changes

@francesco-ooops francesco-ooops francesco-ooops approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 migration needs review ready to merge
Projects
None yet
Milestone
14.0
Development

Successfully merging this pull request may close these issues.
10 participants
@AshishHirapara @rousseldenis @elvise @OCA-git-bot @alexey-pelykh @francesco-ooops @mourad-ehm @sebastienbeau @oca-travis @SicurSam