Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][MIG]sale_discount_display_amount #2038

Merged
merged 41 commits into from
Jun 2, 2022
Merged

[15.0][MIG]sale_discount_display_amount #2038

merged 41 commits into from
Jun 2, 2022

Conversation

manuelregidor
Copy link
Contributor

Supersedes: #1914

Cédric Pigeon and others added 30 commits June 1, 2022 13:42
@manuelregidor
[ADD] add new module to display discount amount on sale orders
7260acf
@oca-travis @manuelregidor
[UPD] Update sale_discount_display_amount.pot
ccf525b
@OCA-git-bot @manuelregidor
[UPD] README.rst
f19e010
@manuelregidor
Added translation using Weblate (French)
8c30382
@manuelregidor
Added translation using Weblate (Spanish)
5b7306c
@Abranes @manuelregidor
[12.0][MIG] sale_discount_display_amount
d71c709
@OCA-git-bot @manuelregidor
[UPD] README.rst
c06ce19
@oca-travis @manuelregidor
[UPD] Update sale_discount_display_amount.pot
6966e80
@oca-transbot @manuelregidor
Update translation files
af3ea0f 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-12.0/sale-workflow-12.0-sale_discount_display_amount
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_discount_display_amount/
@marylla @manuelregidor
Added translation using Weblate (German)
4250c86
@marylla @manuelregidor
Translated using Weblate (German)
b2c5f7e 
Currently translated at 100.0% (4 of 4 strings)

Translation: sale-workflow-12.0/sale-workflow-12.0-sale_discount_display_amount
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_discount_display_amount/de/
@OCA-git-bot @manuelregidor
[UPD] README.rst
aba7579
@liweijie0812 @manuelregidor
Added translation using Weblate (Chinese (Simplified))
1c84c10
@liweijie0812 @manuelregidor
Translated using Weblate (Chinese (Simplified))
9b92aeb 
Currently translated at 100.0% (4 of 4 strings)

Translation: sale-workflow-12.0/sale-workflow-12.0-sale_discount_display_amount
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_discount_display_amount/zh_CN/
@manuelregidor
[IMP] sale_discount_display_amount: black, isort
558f081
@manuelregidor
[MIG] sale_discount_display_amount: Migration to 13.0
8621481
@lmignon @manuelregidor
[MIG] sale_discount_display_amount: Computed values must be reset by …
fa7b7d5 
…the compute method
@manuelregidor
[IMP] sale_discount_display_amount rename view
537aec0
@oca-travis @manuelregidor
[UPD] Update sale_discount_display_amount.pot
deec02b
@OCA-git-bot @manuelregidor
[UPD] README.rst
d436ce0
@oca-transbot @manuelregidor
Update translation files
e978b89 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-13.0/sale-workflow-13.0-sale_discount_display_amount
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-sale_discount_display_amount/
@OCA-git-bot @manuelregidor
pre-commit update
c5a7901
@pedrobaeza @manuelregidor
[FIX] sale_discount_display_amount: Guidelines in compute methods names
efbfd06 
If not, it can collide with other modules defining the same compute name, so let's
follow the guidelines and name properly the method.
@danimv5 @manuelregidor
Translated using Weblate (Spanish)
bccff76 
Currently translated at 100.0% (4 of 4 strings)

Translation: sale-workflow-13.0/sale-workflow-13.0-sale_discount_display_amount
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-sale_discount_display_amount/es/
@chafique-delli @manuelregidor
[MIG] sale_discount_display_amount: Migration to 14.0
0c536cc 
[FIX] README.rst
@oca-travis @manuelregidor
[UPD] Update sale_discount_display_amount.pot
e799c87
@OCA-git-bot @manuelregidor
[UPD] README.rst
20285cc
@OCA-git-bot @manuelregidor
sale_discount_display_amount 14.0.1.0.1
3207d5d
@bosd @manuelregidor
Added translation using Weblate (Dutch)
6dd6ed8
@bosd @manuelregidor
Translated using Weblate (Dutch)
e820ac8 
Currently translated at 100.0% (7 of 7 strings)

Translation: sale-workflow-14.0/sale-workflow-14.0-sale_discount_display_amount
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_discount_display_amount/nl/
danimv5 and others added 11 commits June 1, 2022 13:42
@danimv5 @manuelregidor
Added translation using Weblate (Catalan)
bff93f3
@danimv5 @manuelregidor
Translated using Weblate (Catalan)
4af9d0d 
Currently translated at 100.0% (7 of 7 strings)

Translation: sale-workflow-14.0/sale-workflow-14.0-sale_discount_display_amount
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_discount_display_amount/ca/
@marylla @manuelregidor
Translated using Weblate (German)
f975b77 
Currently translated at 100.0% (4 of 4 strings)

Translation: sale-workflow-14.0/sale-workflow-14.0-sale_discount_display_amount
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_discount_display_amount/de/
@simahawk @manuelregidor
sale_discount_display_amount: fix init hook
ee29bea 
Prevent failure if new columns are already in DB.
@OCA-git-bot @manuelregidor
sale_discount_display_amount 14.0.1.0.2
5f810f5
@rousseldenis @manuelregidor
[14.0][IMP] sale_discount_display_amount: Adds hook for depends
961a5a3
@OCA-git-bot @manuelregidor
sale_discount_display_amount 14.0.1.0.3
4dbb660
@francesco-ooops @manuelregidor
Added translation using Weblate (Italian)
fe91613
@francesco-ooops @manuelregidor
Translated using Weblate (Italian)
de327da 
Currently translated at 100.0% (7 of 7 strings)

Translation: sale-workflow-14.0/sale-workflow-14.0-sale_discount_display_amount
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_discount_display_amount/it/
@manuelregidor
[IMP] sale_discount_display_amount: black, isort, prettier
8669452
@manuelregidor
[MIG]sale_discount_display_amount: Migration to 15.0
d6d322f
@manuelregidor
Copy link
Contributor Author

@HaraldPanten @ValentinVinagre

ValentinVinagre
ValentinVinagre approved these changes Jun 1, 2022
View reviewed changes
Copy link
Contributor

@ValentinVinagre ValentinVinagre left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@HaraldPanten
Copy link
Contributor

/ocabot migration sale_discount_display_amount

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Jun 2, 2022
@OCA-git-bot OCA-git-bot mentioned this pull request Jun 2, 2022
Open
@HaraldPanten
Copy link
Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 15.0-ocabot-merge-pr-2038-by-HaraldPanten-bump-patch, awaiting test results.

@HaraldPanten HaraldPanten mentioned this pull request Jun 2, 2022
Closed
@OCA-git-bot OCA-git-bot merged commit bee898b into OCA:15.0 Jun 2, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 7e070c1. Thanks a lot for contributing to OCA. ❤️

@HaraldPanten HaraldPanten deleted the 15.0-mig-sale_discount_display_amount branch June 2, 2022 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ValentinVinagre ValentinVinagre ValentinVinagre approved these changes

@HaraldPanten HaraldPanten HaraldPanten approved these changes

@ajaniszewska-dev ajaniszewska-dev ajaniszewska-dev approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.