Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][MIG] sale_order_product_recommendation: Migration to 15.0 #2052

Merged
merged 26 commits into from
Jul 26, 2022
Merged

[15.0][MIG] sale_order_product_recommendation: Migration to 15.0 #2052

merged 26 commits into from
Jul 26, 2022

Conversation

cesar-tecnativa
Copy link
Contributor

@cesar-tecnativa cesar-tecnativa commented Jun 6, 2022 •
edited
Loading

@Tecnativa TT36525

@cesar-tecnativa
Copy link
Contributor Author

@sergio-teruel please review

@cesar-tecnativa cesar-tecnativa force-pushed the 15.0-mig-sale_order_product_recommendation branch 2 times, most recently from 0908a2b to f0f3b9e Compare June 6, 2022 16:18
@cesar-tecnativa cesar-tecnativa force-pushed the 15.0-mig-sale_order_product_recommendation branch 2 times, most recently from 011571b to 0e083cd Compare June 8, 2022 15:16
@willytal
Copy link

Please include #2065

@rousseldenis
Copy link
Sponsor Contributor

@cesar-tecnativa Could you fix tests ? Thanks

@cesar-tecnativa cesar-tecnativa force-pushed the 15.0-mig-sale_order_product_recommendation branch from 0e083cd to dbf0d46 Compare June 16, 2022 11:03
@cesar-tecnativa
Copy link
Contributor Author

Please include #2065

Done

@sergio-teruel
Copy link
Contributor

@cesar-tecnativa please... fix the tests

@cesar-tecnativa cesar-tecnativa force-pushed the 15.0-mig-sale_order_product_recommendation branch from 9536fe2 to ae405cc Compare June 28, 2022 08:42
@cesar-tecnativa
Copy link
Contributor Author

@victoralmau Could you please review this PR?

pedrobaeza
pedrobaeza reviewed Jun 28, 2022
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cherry-pick the commit for the new UoM column and put it before the migration

sale_order_product_recommendation/security/ir.model.access.csv Outdated Show resolved Hide resolved
@cesar-tecnativa cesar-tecnativa force-pushed the 15.0-mig-sale_order_product_recommendation branch from ae405cc to 5074f9c Compare June 28, 2022 15:33
@cesar-tecnativa cesar-tecnativa force-pushed the 15.0-mig-sale_order_product_recommendation branch 4 times, most recently from a8933de to f812ab6 Compare June 29, 2022 13:10
@pedrobaeza
Copy link
Member

/ocabot migration sale_order_product_recommendation

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Jun 29, 2022
@OCA-git-bot OCA-git-bot mentioned this pull request Jun 29, 2022
Open
pedrobaeza
pedrobaeza requested changes Jun 29, 2022
View reviewed changes
sale_order_product_recommendation/i18n/pt_BR.po Outdated Show resolved Hide resolved
sale_order_product_recommendation/tests/test_recommendation.py Show resolved Hide resolved
sale_order_product_recommendation/views/sale_order_view.xml Show resolved Hide resolved
sale_order_product_recommendation/views/sale_order_view.xml Outdated Show resolved Hide resolved
sale_order_product_recommendation/wizards/sale_order_recommendation.py Outdated Show resolved Hide resolved
sale_order_product_recommendation/wizards/sale_order_recommendation.py Show resolved Hide resolved
sale_order_product_recommendation/wizards/sale_order_recommendation.py Outdated Show resolved Hide resolved
sale_order_product_recommendation/wizards/sale_order_recommendation_view.xml Outdated Show resolved Hide resolved
@cesar-tecnativa cesar-tecnativa force-pushed the 15.0-mig-sale_order_product_recommendation branch 2 times, most recently from c57bcee to 566d887 Compare June 30, 2022 13:50
@cesar-tecnativa
Copy link
Contributor Author

@chienandalu could you please review this?

@cesar-tecnativa
Copy link
Contributor Author

@LudLaf could you review this?

pedrobaeza and others added 11 commits July 26, 2022 09:45
@pedrobaeza @cesar-tecnativa
[IMP] sale_order_product_recommendation: Remove useless flag `is_modi…
2ec1f12 
…fied`

It's better to simply check the flag condition than to keep that field.
@pedrobaeza @cesar-tecnativa
[FIX] sale_order_recommendation_secondary_unit: Don't tie second. uni…
044be81 
…t to product default one

Having a related field to default sale secondary UoM makes this recommendator to not fit
possible different secondary UoM to be used.

This commit fixes this behavior. A refactoring on the main module having a prepare
method hook has been needed.
@pedrobaeza @cesar-tecnativa
[IMP] sale_order_product_recommendation*: Use Form for populating onc…
ced881c 
…hanges

Previous code was not very resilient to possible extra adaptations or require
specific code to be added to the old hook `_trigger_so_line_onchanges`.

With this, we make sure all onchanges are executed thanks to the odoo.tests.Form
class.

We lose a bit of performance, but it's better than to have issues with data not
correctly synchronized.
@pedrobaeza @cesar-tecnativa
[FIX] sale_order_product_recommendation: Use odoo.tests.Form as sudo
65fec40 
For avoiding errors like accessing mail.tracking.value when changing values.
@sergio-teruel @cesar-tecnativa
[FIX] sale_order_product_recommendation: Get product image form produ…
741a14a 
…ct.product model instead of product.template in wizard kanban view.

TT26749
@sergio-teruel @cesar-tecnativa
[IMP] sale_order_product_recommendation: Allow to display price unit …
8ec02a4 
…from listprice or from last sale order.

TT26727
@sergio-teruel @cesar-tecnativa
[IMP] sale_order_product_recommendation: Allow to display price unit …
d90d2cc 
…from listprice or from last sale order. Computed with ORM instead of sql queries

TT26727
@sergio-teruel @cesar-tecnativa
[IMP] sale_order_product_recommendation: Allow to create a sale order…
9571638 
… line with last_sale_order price unit from recommendation line

TT27183
@victoralmau @cesar-tecnativa
[IMP] sale_order_product_recommendation: When user opens the product …
48a5cb8 
…recommendation wizard always sort by times delivered desc (even if the sale order already has any line)
@cesar-tecnativa
[IMP] sale_order_product_recommendation: Add unit of measure at wizard
7dd3bad
@cesar-tecnativa
[IMP] sale_order_product_recommendation: black, isort, prettier
5f4b658
@cesar-tecnativa cesar-tecnativa force-pushed the 15.0-mig-sale_order_product_recommendation branch 2 times, most recently from ad58800 to 5d30bf7 Compare July 26, 2022 07:47
@cesar-tecnativa cesar-tecnativa force-pushed the 15.0-mig-sale_order_product_recommendation branch from 5d30bf7 to 582b9a8 Compare July 26, 2022 07:47
@LudLaf
Copy link

LudLaf commented Jul 26, 2022

@LudLaf could you review this?

Module functionality is working fine.

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-2052-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit e77b005 into OCA:15.0 Jul 26, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at c233726. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 15.0-mig-sale_order_product_recommendation branch July 26, 2022 16:09
pilarvargas-tecnativa pushed a commit to Tecnativa/sale-workflow that referenced this pull request Feb 7, 2023
@OCA-git-bot
Merge PR OCA#2052 into 15.0
7425bb1 
Signed-off-by pedrobaeza
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LudLaf LudLaf LudLaf approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@sergio-teruel sergio-teruel Awaiting requested review from sergio-teruel

@CarlosRoca13 CarlosRoca13 Awaiting requested review from CarlosRoca13

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.