[15.0][MIG] sale_fixed_discount #2269
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently translated at 100.0% (5 of 5 strings) Translation: sale-workflow-13.0/sale-workflow-13.0-sale_fixed_discount Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-sale_fixed_discount/es/
instead of `sale.group_discount_per_so_line`
The sale order view in the portal was not displaying the fixed discount.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-13.0/sale-workflow-13.0-sale_fixed_discount Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-sale_fixed_discount/
Currently translated at 100.0% (5 of 5 strings) Translation: sale-workflow-13.0/sale-workflow-13.0-sale_fixed_discount Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-sale_fixed_discount/fr/
Rad0van
force-pushed
the
15.0-mig-sale_fixed_discount
branch
from
8636ee0
to
f99d3d2
Compare
|
@LoisRForgeFlow @JordiBForgeFlow @MiquelRForgeFlow @HviorForgeFlow would you please care to have a look at the inner method thing? I am sure there is a better way... |
|
@Rad0van check odoo/odoo@174d52a |
|
Closing as #2485 moved forward better than me. Thanx @ps-tubtim |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As #1601 and #2086 are abandoned and non-functional, here's another attempt. Would be fairly standard but when using in real life it was found that the new json-style summary shows incorrect values. Hence the ugly hack at the end of the file trying to make it work. Nicer way would be to override the inner
compute_taxesmethod but I am not sure how to do that. Any advice is welcome.