Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][MIG] sale_order_general_discount: Migration to version 15.0 #2279

Merged
merged 14 commits into from
Dec 9, 2022

Conversation

stefan-tecnativa
Copy link
Contributor

CC @Tecnativa TT40605

@pedrobaeza @chienandalu Please review

sergio-teruel and others added 13 commits November 24, 2022 10:38
[MIG] Migrated sale_order_general_discount to v13.

[IMP] Improved code as per request.

[IMP][13.0] sale_order_general_discount: rebase with OCA/13.0 + apply pre-commit

[UPD] sale_order_general_discount: update view to display percentage correctly
version conflict prevents upload to pypi
Currently translated at 100.0% (5 of 5 strings)

Translation: sale-workflow-14.0/sale-workflow-14.0-sale_order_general_discount
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_order_general_discount/it/
@stefan-tecnativa stefan-tecnativa force-pushed the 15.0-mig-sale_order_general_discount branch 2 times, most recently from 0a53c62 to aeb15b1 Compare November 24, 2022 12:48
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stefan-tecnativa ! Here you have some suggestions:

sale_order_general_discount/views/sale_order_view.xml Outdated Show resolved Hide resolved
sale_order_general_discount/models/sale_order_line.py Outdated Show resolved Hide resolved
sale_order_general_discount/readme/ROADMAP.rst Outdated Show resolved Hide resolved
sale_order_general_discount/readme/CONTRIBUTORS.rst Outdated Show resolved Hide resolved
@stefan-tecnativa stefan-tecnativa force-pushed the 15.0-mig-sale_order_general_discount branch from aeb15b1 to 12df24e Compare November 25, 2022 10:55
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks!

@pedrobaeza
Copy link
Member

/ocabot migration sale_order_general_discount

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Nov 26, 2022
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-2279-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit 2e57a3f into OCA:15.0 Dec 9, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 6dd6786. Thanks a lot for contributing to OCA. ❤️

pilarvargas-tecnativa pushed a commit to Tecnativa/sale-workflow that referenced this pull request Feb 7, 2023
Signed-off-by pedrobaeza
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.