Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0] [MIG] sale_order_line_date #2341

Merged
merged 52 commits into from
Jun 28, 2023
Merged

[16.0] [MIG] sale_order_line_date #2341

merged 52 commits into from
Jun 28, 2023

Conversation

Kev-Roche
Copy link
Contributor

No description provided.

AaronHForgeFlow and others added 30 commits January 17, 2023 12:55
@AaronHForgeFlow @Kev-Roche
Update code
add0196 
[FIX] Update readme to latest template
@serpentcs-dev1 @Kev-Roche
sale_order_line_date v9
c7e44da
@oca-transbot @Kev-Roche
OCA Transbot updated translations from Transifex
cc58f59
@nikul-serpentcs @Kev-Roche
[MIG] sale_order_line_date v10
0091ee0
@oca-transbot @Kev-Roche
OCA Transbot updated translations from Transifex
ae415a3
@OpenCode @Kev-Roche
[MIG] sale_order_line_date: Migration to 11.0
15d4595
@OpenCode @Kev-Roche
[FIX] Function name to prepare procurement values
d305997
@oca-travis @Kev-Roche
[UPD] Update sale_order_line_date.pot
6561323
@OCA-git-bot @Kev-Roche
[ADD] icon.png
c6ad1b2
@marylla @Kev-Roche
Translated using Weblate (German)
8a8c500 
Currently translated at 100.0% (3 of 3 strings)

Translation: sale-workflow-11.0/sale-workflow-11.0-sale_order_line_date
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-11-0/sale-workflow-11-0-sale_order_line_date/de/
@open-net-sarl @Kev-Roche
[MIG] sale_order_line_date: Migration to 12.0
728a286
@Kev-Roche
[MIG] 12.0 sale_order_line_date
322c79f
@grindtildeath @mpanarin @Kev-Roche
[IMP] Add segurity group in views
92b4ef1 
Co-Authored-By: mpanarin <[email protected]>
@gurneyalex @Kev-Roche
[UPD] Readme
0a37397
@MiquelRForgeFlow @Kev-Roche
[FIX] Final touches of migration to v12
8be9bca
@oca-travis @Kev-Roche
[UPD] Update sale_order_line_date.pot
b7e8f67
@OCA-git-bot @Kev-Roche
[UPD] README.rst
1d06575
@oca-transbot @Kev-Roche
Update translation files
b1d82cd 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-12.0/sale-workflow-12.0-sale_order_line_date
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_order_line_date/
@Kev-Roche
Translated using Weblate (Portuguese (Brazil))
c5cf0b5 
Currently translated at 100.0% (3 of 3 strings)

Translation: sale-workflow-12.0/sale-workflow-12.0-sale_order_line_date
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_order_line_date/pt_BR/
@NuriaXifre @Kev-Roche
[IMP] sale_order_line_date: black, isort
8cbca8b
@NuriaXifre @Kev-Roche
[13.0][MIG] sale_order_line_date
7391b00
@oca-travis @Kev-Roche
[UPD] Update sale_order_line_date.pot
b9d7098
@OCA-git-bot @Kev-Roche
[UPD] README.rst
80b8547
@oca-transbot @Kev-Roche
Update translation files
36021ff 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-13.0/sale-workflow-13.0-sale_order_line_date
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-sale_order_line_date/
@OCA-git-bot @Kev-Roche
pre-commit update
61ea157
@danimv5 @Kev-Roche
Translated using Weblate (Spanish)
18d9ced 
Currently translated at 100.0% (4 of 4 strings)

Translation: sale-workflow-13.0/sale-workflow-13.0-sale_order_line_date
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-sale_order_line_date/es/
@oca-transbot @Kev-Roche
Update translation files
54eddfc 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-13.0/sale-workflow-13.0-sale_order_line_date
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-sale_order_line_date/
@MiquelRForgeFlow @Kev-Roche
[UPD] Eficent -> ForgeFlow
01faa04
@dennybiasiolli @Kev-Roche
[IMP] sale_order_line_date: improving commitment_date tree column
4f26e96 
allowing users to hide the column from the tree
@OCA-git-bot @Kev-Roche
sale_order_line_date 13.0.1.1.0
21bce65
@Kev-Roche Kev-Roche force-pushed the 16.0-mig-sale_order_line_date branch from 030d2fb to fef0d25 Compare April 11, 2023 12:31
@hugo-cordoba
Copy link
Contributor

Hi @Kev-Roche, could you check the tests that are failing?

Regards!

BT-anieto
BT-anieto reviewed Apr 19, 2023
View reviewed changes
Copy link

@BT-anieto BT-anieto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thx for your contribution. Just a comment. Could you check why the tests are not passing? Thank you :)

sale_order_line_date/tests/test_sale_order_line_date.py Outdated
from odoo.tests.common import SavepointCase


class TestSaleOrderLineDates(SavepointCase):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SavepointCase is deprecated. You should use TransactionCase

Copy link
Sponsor Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kev-Roche

BT-anieto
BT-anieto reviewed Apr 19, 2023
View reviewed changes
sale_order_line_date/tests/test_sale_order_line_date.py Outdated
cls.sale2, product_id, qty, price, cls.dt1
)

def _create_sale_order(self, customer, date):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests are failing because you are using now this function inside setUpCls. Then, please add this function the @classmethod decorator and change self by cls. Same with the _create_sale_order_line method
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BT-anieto thank you, I fixed it

@CasVissers-360ERP
Copy link

We have #2421 #2432 #2341 for the same module, which one is going to be used? I suggest #2341

CasVissers-360ERP
CasVissers-360ERP approved these changes Apr 19, 2023
View reviewed changes
Copy link

@CasVissers-360ERP CasVissers-360ERP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review

@Kev-Roche Kev-Roche force-pushed the 16.0-mig-sale_order_line_date branch 3 times, most recently from df9c3a8 to b9b067d Compare April 26, 2023 07:21
hugo-cordoba
hugo-cordoba approved these changes Apr 26, 2023
View reviewed changes
Copy link
Contributor

@hugo-cordoba hugo-cordoba left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (code review)

@ferran-S73
Copy link
Contributor

Aside from the TransactionCase change LGTM

@Kev-Roche Kev-Roche force-pushed the 16.0-mig-sale_order_line_date branch from b9b067d to 64d03e7 Compare June 14, 2023 13:24
@Kev-Roche
Copy link
Contributor Author

Aside from the TransactionCase change LGTM

Indeed,I fix it.

@ferran-S73
Copy link
Contributor

ferran-S73 commented Jun 14, 2023 •
edited
Loading

Also it'd be nice if you could apply this commit 007ecba that was recently merged in v14

@Kev-Roche
Copy link
Contributor Author

Also it'd be nice if you could apply this commit 007ecba that was recently merged in v14

@ferran-S73 also done.

@bosd
Copy link
Contributor

bosd commented Jun 22, 2023

@rousseldenis Kindly check this one...
Seems your changes are incorporated.. Can you re-review?

@rousseldenis
Copy link
Sponsor Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-2341-by-rousseldenis-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit b3a8852 into OCA:16.0 Jun 28, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 560733c. Thanks a lot for contributing to OCA. ❤️

@zamberjo zamberjo mentioned this pull request Jun 30, 2023
Closed
@rafaelbn
Copy link
Member

rafaelbn commented Aug 7, 2023

/ocabot migration sale_order_line_date

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BT-anieto BT-anieto BT-anieto left review comments

@rousseldenis rousseldenis rousseldenis approved these changes

@CasVissers-360ERP CasVissers-360ERP CasVissers-360ERP approved these changes

@ferran-S73 ferran-S73 ferran-S73 approved these changes

@aliciagaarzo aliciagaarzo aliciagaarzo approved these changes

@hugo-cordoba hugo-cordoba hugo-cordoba approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 migration needs review
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.