-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[15.0][MIG] sale_cancel_reason #2400
Conversation
(../trunk-generic/ rev 29.1.1)
(../trunk-generic/ rev 32.1.1)
(../trunk-generic/ rev 32.1.2)
- Update travis.yml to 8.0
Only hide button instead of renaming it
In order to get visibility on https://www.odoo.com/apps the OCA board has decided to add the OCA as author of all the addons maintained as part of the association.
… of sale_cancel_reason module
* [MIG] sale_cancel_reason Migration to 10.0 * Follow coding standard * Convert test to unittest2
Updated by Actualizar ficheiros PO com o novo POT (msgmerge) hook in Weblate.
Currently translated at 100.0% (23 of 23 strings) Translation: sale-workflow-10.0/sale-workflow-10.0-sale_cancel_reason Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-10-0/sale-workflow-10-0-sale_cancel_reason/pt/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-12.0/sale-workflow-12.0-sale_cancel_reason Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_cancel_reason/
The tests not working are from another modules trying to cancel a Sale Order. With this module a wizard is showed when trying to cancel a sale order, so a simple so.button_cancel() in a test doesn't work anymore. That's why the other modules tests are not working. |
/ocabot migration sale_cancel_reason |
@DavidJForgeFlow A better way of implementing this is to add a configuration parameter to activate or not the cancel reason (e.g.: on company level). This allows this module coexist with other that use the cancel flow too and tests passing |
@ao-landoo Do you mind if we switch to this instead your PR? |
The migration issue (#1741) has been updated to reference the current pull request. |
Hi @rousseldenis, I've commited a solution like you said. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review
Hello, is there any ETA for this to be merged? |
/ocabot merge nobump |
On my way to merge this fine PR! |
It looks like something changed on |
Congratulations, your PR was merged at cd03d08. Thanks a lot for contributing to OCA. ❤️ |
Supersede #2178
Standard Migration to 15.0
@ForgeFlow