Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] sale_order_secondary_unit #2486

Closed
wants to merge 31 commits into from

Conversation

remihb
Copy link

@remihb remihb commented Apr 18, 2023

With changes introduced by #2331 for 15.0 (Compatibility with product variants)

Wait for OCA/product-attribute#1325 to be merged

sergio-teruel and others added 30 commits April 16, 2023 14:31
Added domain to limit `secondary_uom_id` to the one defined in product template
As the test should only test that no change on the UoM quantity is done
when modifying the secondary unit, we remember the existing quantity and
compare it later with the final value, instead of testing against a
fixed value, so any interaction with other modules don't interfere.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-15.0/sale-workflow-15.0-sale_order_secondary_unit
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_order_secondary_unit/
@remihb remihb force-pushed the 16.0-mig-sale_order_secondary_unit branch from 39a1fe5 to a36d085 Compare April 18, 2023 16:55
@BT-aleonard
Copy link

BT-aleonard commented Apr 19, 2023

@remihb Thanks for your contribution,
Can you add this PR to the OCA's issues on #2215 and fix the tests?
Thanks 💯

@remihb remihb changed the title [16.0][MIG] sale order secondary unit [16.0][MIG] sale_order_secondary_unit Apr 19, 2023
@remihb remihb mentioned this pull request Apr 19, 2023
97 tasks
@rousseldenis
Copy link
Sponsor Contributor

/ocabot migration sale_order_secondary_unit

@remihb remihb force-pushed the 16.0-mig-sale_order_secondary_unit branch from a36d085 to b7b9454 Compare April 27, 2023 14:16
@pedrobaeza
Copy link
Member

Please cherry-pick #2331

@nicolascol
Copy link

Could you repair runboat? I want to test the module
@remihb

@desdelinux
Copy link

ping @remihb

@rafaelbn
Copy link
Member

rafaelbn commented Aug 4, 2023

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

@rafaelbn The rebase process failed, because command git push --force osiell tmp-pr-2486:16.0-mig-sale_order_secondary_unit failed with output:

remote: Permission to osiell/sale-workflow.git denied to OCA-git-bot.
fatal: unable to access 'https:/osiell/sale-workflow/': The requested URL returned error: 403

@fcvalgar
Copy link

fcvalgar commented Aug 4, 2023

/ocabot rebase

@rafaelbn please rebase, thank you

@rafaelbn
Copy link
Member

rafaelbn commented Aug 5, 2023

Hello @remihb , are you going to continue with this PR? Let me know please. Thanks.

@rafaelbn
Copy link
Member

Superseded by #2635

Closing as no answer

@rafaelbn rafaelbn closed this Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.