Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] sale_order_product_recommendation: Migration to version 16.0 #2491

Merged
merged 44 commits into from
Jun 6, 2023
Merged

[16.0][MIG] sale_order_product_recommendation: Migration to version 16.0 #2491

merged 44 commits into from
Jun 6, 2023

Conversation

Yadier-Tecnativa
Copy link
Contributor

@Tecnativa TT42432

@rousseldenis
Copy link
Sponsor Contributor

/ocabot migration sale_order_product_recommendation

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Apr 25, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Apr 25, 2023
Open
97 tasks
@Yadier-Tecnativa Yadier-Tecnativa force-pushed the 16.0-mig-sale_order_product_recommendation branch 4 times, most recently from 01c2e58 to cc59c13 Compare April 25, 2023 19:50
@Yadier-Tecnativa Yadier-Tecnativa force-pushed the 16.0-mig-sale_order_product_recommendation branch from cc59c13 to 3ceede3 Compare May 4, 2023 12:45
@pedrobaeza
Copy link
Member

The width of the one2many is not fitting the whole width.

@Yadier-Tecnativa Yadier-Tecnativa force-pushed the 16.0-mig-sale_order_product_recommendation branch 2 times, most recently from 5b409de to 9367f99 Compare May 5, 2023 16:30
@Yadier-Tecnativa
Copy link
Contributor Author

The width of the one2many is not fitting the whole width.

changed

@pedrobaeza
Copy link
Member

OK, the CI error is on other module and doesn't seem related to this.

@Yadier-Tecnativa Yadier-Tecnativa force-pushed the 16.0-mig-sale_order_product_recommendation branch 10 times, most recently from e4ee1c4 to 7e34ef9 Compare May 16, 2023 16:01
@Yadier-Tecnativa
Copy link
Contributor Author

Yadier-Tecnativa commented May 16, 2023 •
edited
Loading

After many attempts to change the installation modules failed in the CI jobs, the error remains the same:
ERROR: statement cancel due to lock timeout
It seems something with the database implementation.

ping @pedrobaeza

@sergio-teruel sergio-teruel force-pushed the 16.0-mig-sale_order_product_recommendation branch from 83dffce to 3cad38d Compare June 2, 2023 20:01
@sergio-teruel sergio-teruel force-pushed the 16.0-mig-sale_order_product_recommendation branch 6 times, most recently from 7730c85 to cad7918 Compare June 4, 2023 08:28
@sergio-teruel
Copy link
Contributor

ping @chienandalu

@sergio-teruel sergio-teruel force-pushed the 16.0-mig-sale_order_product_recommendation branch from cad7918 to 8cf55fe Compare June 5, 2023 13:33
@sergio-teruel
Copy link
Contributor

Ready to be merged!!

@sergio-teruel sergio-teruel force-pushed the 16.0-mig-sale_order_product_recommendation branch from 8cf55fe to cf13d8e Compare June 5, 2023 13:52
@sergio-teruel
Copy link
Contributor

ping @Juangomezzurita

@sergio-teruel sergio-teruel force-pushed the 16.0-mig-sale_order_product_recommendation branch from cf13d8e to 1dc16b0 Compare June 5, 2023 13:55
pedrobaeza
pedrobaeza reviewed Jun 5, 2023
View reviewed changes
.pre-commit-config.yaml Outdated
@@ -1,6 +1,7 @@
exclude: |
(?x)
# NOT INSTALLABLE ADDONS
^sale_automatic_workflow/|
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one should be removed, isn't it?

@sergio-teruel sergio-teruel force-pushed the 16.0-mig-sale_order_product_recommendation branch from 1dc16b0 to 1402435 Compare June 6, 2023 07:43
@sergio-teruel
Copy link
Contributor

Done!! waiting to CI

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-2491-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 0b75089 into OCA:16.0 Jun 6, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at b32e851. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza left review comments

@sergio-teruel sergio-teruel sergio-teruel requested changes

@chienandalu chienandalu chienandalu approved these changes

Assignees
No one assigned
Labels
merged 🎉 migration needs review
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.