[MIG] sale_order_carrier_auto_assign: Migration to 16.0 #2533
Conversation
Currently translated at 100.0% (1 of 1 strings) Translation: sale-workflow-13.0/sale-workflow-13.0-sale_order_carrier_auto_assign Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-sale_order_carrier_auto_assign/es/
matiasperalta1
force-pushed
the
16.0-mig-sale_order_carrier_auto_assign
branch
from
4936ef2
to
1f319e2
Compare
|
This PR has the |
|
/ocabot migration sale_order_carrier_auto_assign |
| _inherit = "sale.order" | ||
|
|
||
| def action_confirm(self): | ||
| if config["test_enable"] and not self.env.context.get( |
There was a problem hiding this comment.
@matiasperalta1 @grindtildeath I don't like such code. Better to add a setting to enable the behaviour that breaks standard one. But not blocking
There was a problem hiding this comment.
@matiasperalta1 Could you put at least in ROADMAP we need to add a configuration setting ?
There was a problem hiding this comment.
@rousseldenis I mplemented that in another PR:
#2837
There was a problem hiding this comment.
Why adding this in an other PR ? Would you not prefer to include it here ?
There was a problem hiding this comment.
I would prefer. But probably @matiasperalta1 did not had opportunity to implement that.
|
/ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
|
It looks like something changed on |
|
Congratulations, your PR was merged at 1342462. Thanks a lot for contributing to OCA. ❤️ |
No description provided.