Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] sale_elaboration: Migration to version 16.0 #2537

Merged
merged 33 commits into from
Jun 5, 2023

Conversation

ernestotejeda
Copy link
Member

Cc @Tecnativa TT42428

sergio-teruel and others added 30 commits May 31, 2023 10:50
Currently translated at 36.7% (11 of 30 strings)

Translation: sale-workflow-11.0/sale-workflow-11.0-sale_elaboration
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-11-0/sale-workflow-11-0-sale_elaboration/de/
…sale order view to store the value in onchange method
…to allow users display elaboration notes on delivery slips
[FIX] sale_elaboration: name_search don't search by name after change rec_name to code
@ernestotejeda
Copy link
Member Author

ping @sergio-teruel @CarlosRoca13

uom=elaboration.product_id.uom_id.id,
).price
line.elaboration_price_unit = elab_price
for line in self.filtered(lambda r: r.order_id.pricelist_id):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure that doing the filtered don't have missing cache error?
The elaboration_price is not stored.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested again and I am not getting an error.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oks.. thanks!!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that this field is stored, so no possibility of miss cache, but I would say this will take False value instead of 0.0 with this code. Can you please check?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You all right @pedrobaeza , thanks, I corrected it, please check it out.

@sergio-teruel
Copy link
Contributor

ping @Juangomezzurita

@pedrobaeza
Copy link
Member

/ocabot migration sale_elaboration

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Jun 3, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Jun 3, 2023
97 tasks
@sergio-teruel
Copy link
Contributor

ping @pedrobaeza

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-2537-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 9bd0505 into OCA:16.0 Jun 5, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 52f273d. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants