Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][IMP] sale_order_line_sequence: module refactor, new sequence fields for orders and invoices #2603

Merged
merged 1 commit into from
Aug 11, 2023
Merged

[14.0][IMP] sale_order_line_sequence: module refactor, new sequence fields for orders and invoices #2603

merged 1 commit into from
Aug 11, 2023

Conversation

OriolMForgeFlow
Copy link
Contributor

Module refactor

@OriolMForgeFlow OriolMForgeFlow force-pushed the 14.0-imp-sale_order_line_sequence-refactor_sequence_fields branch 3 times, most recently from d8a86f2 to ea2c3a0 Compare July 14, 2023 07:40
@OriolMForgeFlow OriolMForgeFlow mentioned this pull request Jul 14, 2023
Merged
@AaronHForgeFlow
Copy link
Contributor

Works well overall, however, if I create the invoice and then I modify the order in the sales order then the invoice order is not changed. I think it should change.

@OriolMForgeFlow OriolMForgeFlow force-pushed the 14.0-imp-sale_order_line_sequence-refactor_sequence_fields branch 4 times, most recently from c1e9784 to ba99280 Compare July 14, 2023 10:35
@OriolMForgeFlow
Copy link
Contributor Author

Changed @AaronHForgeFlow , I think it works fine now.

@rousseldenis rousseldenis added this to the 14.0 milestone Jul 14, 2023
AaronHForgeFlow
AaronHForgeFlow approved these changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional tests. Works good. Tested with invoice splitting.

@OriolMForgeFlow OriolMForgeFlow force-pushed the 14.0-imp-sale_order_line_sequence-refactor_sequence_fields branch from ba99280 to e835ace Compare July 17, 2023 06:35
@AaronHForgeFlow AaronHForgeFlow mentioned this pull request Aug 8, 2023
Merged
LoisRForgeFlow
LoisRForgeFlow approved these changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technical review, LGTM!

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

rafaelbn
rafaelbn approved these changes Aug 11, 2023
View reviewed changes
Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabor merge major

@AaronHForgeFlow
Copy link
Contributor

@rafaelbn there is a typo in the runbot command, can you please retry? Thanks :)

@rafaelbn
Copy link
Member

/ocabot merge major

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-2603-by-rafaelbn-bump-major, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 24b3555 into OCA:14.0 Aug 11, 2023
10 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at cdee328. Thanks a lot for contributing to OCA. ❤️

This was referenced Aug 11, 2023
Merged
Merged
@OriolMForgeFlow OriolMForgeFlow mentioned this pull request Nov 17, 2023
Merged
@LoisRForgeFlow LoisRForgeFlow deleted the 14.0-imp-sale_order_line_sequence-refactor_sequence_fields branch November 23, 2023 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaelbn rafaelbn rafaelbn approved these changes

@AaronHForgeFlow AaronHForgeFlow AaronHForgeFlow approved these changes

@LoisRForgeFlow LoisRForgeFlow LoisRForgeFlow approved these changes

Assignees
No one assigned
Labels
approved enhancement merged 🎉 needs review ready to merge
Projects
None yet
Milestone
14.0
Development

Successfully merging this pull request may close these issues.
6 participants
@OriolMForgeFlow @AaronHForgeFlow @OCA-git-bot @rafaelbn @LoisRForgeFlow @rousseldenis