Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][MIG] sale_procurement_group_by_commitment_date #2618

Merged
merged 13 commits into from
May 18, 2024
Merged

[15.0][MIG] sale_procurement_group_by_commitment_date #2618

merged 13 commits into from
May 18, 2024

Conversation

JasminSForgeFlow
Copy link
Contributor

Standard Migration

@ForgeFlow

AaronHForgeFlow
AaronHForgeFlow reviewed Jul 26, 2023
View reviewed changes
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works good.

Test failing because some non compatibility with other module, need to update rebel module lists

@rousseldenis
Copy link
Sponsor Contributor

/ocabot migration sale_procurement_group_by_commitment_date

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Jul 26, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Jul 26, 2023
Open
@AaronHForgeFlow AaronHForgeFlow force-pushed the 15.0-mig-sale_procurement_group_by_commitment_date branch from a1508a9 to 330d538 Compare October 25, 2023 14:54
@AaronHForgeFlow
Copy link
Contributor

Just rebased. Seems test for the module sale_sourced_by_line are failing. Can you please check @JasminSForgeFlow ?

@JasminSForgeFlow JasminSForgeFlow force-pushed the 15.0-mig-sale_procurement_group_by_commitment_date branch from 330d538 to 0f16d8b Compare October 26, 2023 05:08
@JasminSForgeFlow
Copy link
Contributor Author

Just rebased. Seems test for the module sale_sourced_by_line are failing. Can you please check @JasminSForgeFlow ?

It is fixed, Thanks

@JasminSForgeFlow JasminSForgeFlow force-pushed the 15.0-mig-sale_procurement_group_by_commitment_date branch 2 times, most recently from da4ac23 to 42ad183 Compare October 26, 2023 06:06
SilvioC2C
SilvioC2C approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@SilvioC2C SilvioC2C left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@JasminSForgeFlow @AaronHForgeFlow could you please rebase this PR?

@AaronHForgeFlow AaronHForgeFlow force-pushed the 15.0-mig-sale_procurement_group_by_commitment_date branch from 50b5593 to dfaaa32 Compare November 14, 2023 07:57
MiquelRForgeFlow and others added 12 commits April 19, 2024 17:06
@MiquelRForgeFlow @AaronHForgeFlow
[UPD] Rename to sale_procurement_group_by_commitment_date
5b1bd42
@oca-travis @AaronHForgeFlow
[UPD] Update sale_procurement_group_by_commitment_date.pot
9dabac2
@OCA-git-bot @AaronHForgeFlow
[UPD] README.rst
6cb0626
@ps-tubtim @AaronHForgeFlow
[IMP] sale_procurement_group_by_commitment_date: black, isort, prettier
a3e51b0
@ps-tubtim @AaronHForgeFlow
[MIG] sale_procurement_group_by_commitment_date: Migration to 13.0
d3a05df
@AaronHForgeFlow
[IMP] sale_procurement_group_by_commitment_date: black, isort, prettier
fb6da88
@AaronHForgeFlow
[MIG] sale_procurement_group_by_commitment_date: Migration to 14.0
3fc86e0
@AaronHForgeFlow
[UPD] Update sale_procurement_group_by_commitment_date.pot
580c741
@OCA-git-bot @AaronHForgeFlow
[UPD] README.rst
cca3772
@mymage @AaronHForgeFlow
Translated using Weblate (Italian)
488139c 
Currently translated at 50.0% (1 of 2 strings)

Translation: sale-workflow-14.0/sale-workflow-14.0-sale_procurement_group_by_commitment_date
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_procurement_group_by_commitment_date/it/
@JasminSForgeFlow @AaronHForgeFlow
[IMP] sale_procurement_group_by_commitment_date: black, isort, prettier
67f0341
@JasminSForgeFlow @AaronHForgeFlow
[MIG] sale_procurement_group_by_commitment_date: Migration to 15.0
511cc5e
@AaronHForgeFlow AaronHForgeFlow force-pushed the 15.0-mig-sale_procurement_group_by_commitment_date branch from dfaaa32 to 628421d Compare April 19, 2024 15:06
@AaronHForgeFlow
Copy link
Contributor

Rebased. If still green it is ready for the merge IMHO

PauBForgeFlow
PauBForgeFlow approved these changes Apr 22, 2024
View reviewed changes
Copy link

@PauBForgeFlow PauBForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@dreispt
Copy link
Sponsor Member

dreispt commented May 18, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-2618-by-dreispt-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 5ab2ef3 into OCA:15.0 May 18, 2024
9 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at e9e4318. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyrilmanuel cyrilmanuel cyrilmanuel approved these changes

@AaronHForgeFlow AaronHForgeFlow AaronHForgeFlow approved these changes

@SilvioC2C SilvioC2C SilvioC2C approved these changes

@PauBForgeFlow PauBForgeFlow PauBForgeFlow approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 migration needs review ready to merge
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.