Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[10.0] [IMP]- Move so prd_set to smartbutton header #543

Merged
merged 2 commits into from
Oct 25, 2017
Merged

[10.0] [IMP]- Move so prd_set to smartbutton header #543

merged 2 commits into from
Oct 25, 2017

Conversation

leemannd
Copy link
Contributor

It's way nicer up in the button bar and more close to the guidelines we find in V10.0
prd_set_smart_button and before https:/OCA/sale-workflow/blob/10.0/sale_product_set/static/description/sale_order.png

@leemannd leemannd changed the title 10.0 - Move so prd_set to smartbutton header [10.0] [IMP]- Move so prd_set to smartbutton header Oct 10, 2017
@simahawk
Copy link
Contributor

@leemannd travis lint check red but not because of you: there's bad class naming in tests https://travis-ci.org/OCA/sale-workflow/jobs/285940209

@leemannd leemannd force-pushed the 10.0-imp-sale_product_set branch 5 times, most recently from 8b634e8 to 3de5e9c Compare October 10, 2017 09:44
grindtildeath
grindtildeath approved these changes Oct 11, 2017
View reviewed changes
Copy link
Contributor

@grindtildeath grindtildeath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks !

Would be even nicer if you can add a commit to remove the 'or' string between the buttons in the wizard view, but it's nitpicking.

@leemannd
Copy link
Contributor Author

@grindtildeath Indeed, it is. ;)
PR updated. Needs a squash before merge once validated.

@grindtildeath
Copy link
Contributor

I should also have said "Please increase version number" 😆

LoisRForgeFlow
LoisRForgeFlow approved these changes Oct 13, 2017
View reviewed changes
Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@leemannd
Copy link
Contributor Author

leemannd commented Oct 13, 2017 •
edited
Loading

As I have 3 reviews, I'm squashing it.
Thanks for the reviews.

@leemannd
Copy link
Contributor Author

@pedrobaeza Is it possible to have a review / merge it? Thank you in advance.

dvdhinesh
dvdhinesh approved these changes Oct 20, 2017
View reviewed changes
Copy link
Member

@dvdhinesh dvdhinesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rafaelbn rafaelbn merged commit 8729de6 into OCA:10.0 Oct 25, 2017
rgarnau pushed a commit to ForgeFlow/sale-workflow that referenced this pull request Oct 26, 2017
@leemannd @rgarnau
[10.0] [IMP]- Move so prd_set to smartbutton header (OCA#543)
3f65773 
* [imp] move SO `add set` button to smartbutton header

* [fix] sale_product_set: PEP8
simahawk pushed a commit to simahawk/sale-workflow that referenced this pull request Nov 28, 2017
@leemannd @simahawk
[10.0] [IMP]- Move so prd_set to smartbutton header (OCA#543)
ea49763 
* [imp] move SO `add set` button to smartbutton header

* [fix] sale_product_set: PEP8
simahawk pushed a commit to simahawk/sale-workflow that referenced this pull request Nov 28, 2017
@leemannd @simahawk
[10.0][IMP] sale_product_set: move add set smart button header (OCA…
9e28759 
…#543)

* [imp] move SO `add set` button to smartbutton header

* [fix] sale_product_set: PEP8
ghost pushed a commit to camptocamp/sale-workflow that referenced this pull request Feb 8, 2018
@leemannd
[10.0][IMP] sale_product_set: move add set smart button header (OCA…
eb2520b 
…#543)

* [imp] move SO `add set` button to smartbutton header

* [fix] sale_product_set: PEP8
sbejaoui pushed a commit to sbejaoui/sale-workflow that referenced this pull request Nov 5, 2018
@leemannd @sbejaoui
[10.0][IMP] sale_product_set: move add set smart button header (OCA…
4b38366 
…#543)

* [imp] move SO `add set` button to smartbutton header

* [fix] sale_product_set: PEP8
AdriaGForgeFlow pushed a commit to ForgeFlow/sale-workflow that referenced this pull request Dec 23, 2019
@leemannd @AdriaGForgeFlow
[10.0][IMP] sale_product_set: move add set smart button header (OCA…
1e6aaa8 
…#543)

* [imp] move SO `add set` button to smartbutton header

* [fix] sale_product_set: PEP8
phuctranfxvn pushed a commit to trobz/sale-workflow that referenced this pull request Dec 27, 2020
@leemannd @phuctranfxvn
[10.0][IMP] sale_product_set: move add set smart button header (OCA…
472ecaf 
…#543)

* [imp] move SO `add set` button to smartbutton header

* [fix] sale_product_set: PEP8
SimoneVagile pushed a commit to SimoneVagile/sale-workflow that referenced this pull request Jan 14, 2021
@leemannd @SimoneVagile
[10.0][IMP] sale_product_set: move add set smart button header (OCA…
29ba39c 
…#543)

* [imp] move SO `add set` button to smartbutton header

* [fix] sale_product_set: PEP8
manuelregidor pushed a commit to sygel-technology/sale-workflow that referenced this pull request Jun 1, 2022
@leemannd @manuelregidor
[10.0][IMP] sale_product_set: move add set smart button header (OCA…
d881f70 
…#543)

* [imp] move SO `add set` button to smartbutton header

* [fix] sale_product_set: PEP8
imlopes pushed a commit to camptocamp/sale-workflow that referenced this pull request Sep 15, 2022
@leemannd
[10.0][IMP] sale_product_set: move add set smart button header (OCA…
40cc4c4 
…#543)

* [imp] move SO `add set` button to smartbutton header

* [fix] sale_product_set: PEP8
angelmoya pushed a commit to PESOL/sale-workflow that referenced this pull request Jan 13, 2023
@leemannd @angelmoya
[10.0][IMP] sale_product_set: move add set smart button header (OCA…
beb794f 
…#543)

* [imp] move SO `add set` button to smartbutton header

* [fix] sale_product_set: PEP8
sonhd91 pushed a commit to sonhd91/sale-workflow that referenced this pull request Jan 16, 2023
@leemannd
[10.0][IMP] sale_product_set: move add set smart button header (OCA…
f0faf4e 
…#543)

* [imp] move SO `add set` button to smartbutton header

* [fix] sale_product_set: PEP8
CRogos pushed a commit to c4a8-odoo/module-oca-sale-workflow that referenced this pull request Mar 27, 2023
@leemannd
[10.0][IMP] sale_product_set: move add set smart button header (OCA…
edb720f 
…#543)

* [imp] move SO `add set` button to smartbutton header

* [fix] sale_product_set: PEP8
SoporteOperu pushed a commit to SoporteOperu/sale-workflow that referenced this pull request Mar 29, 2023
@leemannd
[10.0][IMP] sale_product_set: move add set smart button header (OCA…
3b8ee63 
…#543)

* [imp] move SO `add set` button to smartbutton header

* [fix] sale_product_set: PEP8
sonhd91 pushed a commit to sonhd91/sale-workflow that referenced this pull request Mar 30, 2023
@leemannd
[10.0][IMP] sale_product_set: move add set smart button header (OCA…
56e0c53 
…#543)

* [imp] move SO `add set` button to smartbutton header

* [fix] sale_product_set: PEP8
sonhd91 pushed a commit to sonhd91/sale-workflow that referenced this pull request Mar 30, 2023
@leemannd
[10.0][IMP] sale_product_set: move add set smart button header (OCA…
9e0d9ce 
…#543)

* [imp] move SO `add set` button to smartbutton header

* [fix] sale_product_set: PEP8
sonhd91 pushed a commit to sonhd91/sale-workflow that referenced this pull request Mar 30, 2023
@leemannd
[10.0][IMP] sale_product_set: move add set smart button header (OCA…
b821e83 
…#543)

* [imp] move SO `add set` button to smartbutton header

* [fix] sale_product_set: PEP8
heliaktiv pushed a commit to heliaktiv/sale-workflow that referenced this pull request Apr 12, 2023
@leemannd @heliaktiv
[10.0][IMP] sale_product_set: move add set smart button header (OCA…
873306b 
…#543)

* [imp] move SO `add set` button to smartbutton header

* [fix] sale_product_set: PEP8
CRogos pushed a commit to c4a8-odoo/module-oca-sale-workflow that referenced this pull request May 17, 2023
@leemannd
[10.0][IMP] sale_product_set: move add set smart button header (OCA…
5e51f70 
…#543)

* [imp] move SO `add set` button to smartbutton header

* [fix] sale_product_set: PEP8
CRogos pushed a commit to c4a8-odoo/module-oca-sale-workflow that referenced this pull request Jun 23, 2023
@leemannd
[10.0][IMP] sale_product_set: move add set smart button header (OCA…
750800e 
…#543)

* [imp] move SO `add set` button to smartbutton header

* [fix] sale_product_set: PEP8
santostelmo pushed a commit to camptocamp/sale-workflow that referenced this pull request Oct 27, 2023
@leemannd @santostelmo
[10.0][IMP] sale_product_set: move add set smart button header (OCA…
cb53ff0 
…#543)

* [imp] move SO `add set` button to smartbutton header

* [fix] sale_product_set: PEP8
NICO-SOLUTIONS pushed a commit to NICO-SOLUTIONS/sale-workflow that referenced this pull request Jan 9, 2024
@leemannd @NICO-SOLUTIONS
[10.0][IMP] sale_product_set: move add set smart button header (OCA…
da37658 
…#543)

* [imp] move SO `add set` button to smartbutton header

* [fix] sale_product_set: PEP8
NICO-SOLUTIONS pushed a commit to NICO-SOLUTIONS/sale-workflow that referenced this pull request Mar 13, 2024
@leemannd @NICO-SOLUTIONS
[10.0][IMP] sale_product_set: move add set smart button header (OCA…
1948eb1 
…#543)

* [imp] move SO `add set` button to smartbutton header

* [fix] sale_product_set: PEP8
NICO-SOLUTIONS pushed a commit to NICO-SOLUTIONS/sale-workflow that referenced this pull request Mar 26, 2024
@leemannd @NICO-SOLUTIONS
[10.0][IMP] sale_product_set: move add set smart button header (OCA…
8bd6579 
…#543)

* [imp] move SO `add set` button to smartbutton header

* [fix] sale_product_set: PEP8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simahawk simahawk simahawk approved these changes

@grindtildeath grindtildeath grindtildeath approved these changes

@dvdhinesh dvdhinesh dvdhinesh approved these changes

@LoisRForgeFlow LoisRForgeFlow LoisRForgeFlow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@leemannd @simahawk @grindtildeath @dvdhinesh @LoisRForgeFlow @rafaelbn