Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX+IMP] module_analysis : fix analysis during update and make update faster #2058

Conversation

legalsylvain
Copy link
Contributor

Rational

for the time being (before this patch), the update of the analysis is done manually (by Update module List) AND when an update of modules is done (update all, or partial update).
The second analysis is not OK :

  • It is incorrect, because it is partial : module loaded before module_analysis module are not correctly analysed, due to Odoo design. So for exemple, base module is never analysed that way.
  • It makes the update process slower.

Description of the PR

  • Remove analysis when updating modules,

  • Add instead a cron task that is executed nightly to update analysis automatically and fully.

thanks for your review

@legalsylvain legalsylvain force-pushed the 12.0-IMP-FIX-module_analysis-cron-task branch from a412fe7 to 7413749 Compare March 30, 2021 10:23
@github-actions
Copy link

github-actions bot commented Oct 3, 2021

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 3, 2021
@legalsylvain legalsylvain force-pushed the 12.0-IMP-FIX-module_analysis-cron-task branch from 43915c6 to 2422d1b Compare October 20, 2022 11:04
…cause the analysis is partial (it also make the update slower) ; Add instead a cron task that is executed nightly to update analysis automatically
@legalsylvain legalsylvain force-pushed the 12.0-IMP-FIX-module_analysis-cron-task branch from 2422d1b to 0958adf Compare February 19, 2024 08:56
@legalsylvain
Copy link
Contributor Author

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 12.0-ocabot-merge-pr-2058-by-legalsylvain-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Feb 19, 2024
Signed-off-by legalsylvain
@OCA-git-bot
Copy link
Contributor

@legalsylvain your merge command was aborted due to failed check(s), which you can inspect on this commit of 12.0-ocabot-merge-pr-2058-by-legalsylvain-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@thomaspaulb
Copy link
Contributor

Well apparently I hijacked this without knowing, but let's finish it in #2858

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved question stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants