Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][MIG] database_cleanup: Migration to 15.0 #2547

Merged
merged 59 commits into from
Mar 23, 2023

Conversation

yankinmax
Copy link
Contributor

No description provided.

Stefan Rijnhart and others added 30 commits February 9, 2023 12:09
avoid ''NoneType' object has no attribute 'exists'' error when purging models
fix my change [email protected], wrong lines replaced...
    raw SQL query (but never read afterwards). Workaround for
    lp:1277899

[FIX] Preserve dangling workflow table which is in use

[RFR] Group models per table when detecting columns to purge
      to prevent problems with models sharing the same table

[ADD] Allow purging of dangling data entries

[FIX] Data purging now working

[IMP] Docstrings

[FIX] Label
[FIX] Catch attempt to unlink field from nonexisting model

[RFR] Flake8
[CHG] database_cleanup: move description to README.rst
[IMP] order wizard lines by name

[IMP] deal with modules whose models can't be loaded

[IMP] double quotes for docstring

[FIX] use exists query instead of huge in list

[IMP] hide unnecessary buttons in wizard II

[IMP] readability

[FIX] cope with purging nonexisting models
[ADD] test purging modules

[ADD] test purging tables
[FIX] database_cleanup reloads the registry

which has weird side effects during testing. Take care
database_cleanup's tests don't mess up the following tests
* [FIX] database_cleanup: Isolate build
* Isolate `database_cleanup` into its own build in Travis file to fix OCA#689

* [FIX] database_cleanup: Remove KeyError assertion
* Remove KeyError assertion in tests due to PR in comment being merged
* [ADD] allow creating missing indexes

* [FIX] tests; installation

* [ADD] allow purging properties

* [ADD] missing file

* [ADD] test purging properties

* [ADD] missing parent_id for menu entry

* [FIX] don't delete too many and wrong properties
Using new base model inheritance.
[FIX] don't try to uninstall uninstalled modules

[DEL] weird code

[FIX] actually cleanup where we can
Update version number
Use correct import
Update .pot to match new syntax
Adapt icon to fontawesome
Add models description
Rename field external id to new syntax <model>__<field>
@pedrobaeza pedrobaeza changed the title [15.0+[MIG] database_cleanup: Migration to 15.0 [15.0][MIG] database_cleanup: Migration to 15.0 Feb 9, 2023
@pedrobaeza
Copy link
Member

/ocabot migration database_cleanup

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Feb 9, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Feb 9, 2023
54 tasks
@yankinmax
Copy link
Contributor Author

@leemannd @damdam-s can you pls review?

@yankinmax yankinmax force-pushed the 15.0-mig-database_cleanup branch 2 times, most recently from ac15936 to 4e9b35f Compare February 9, 2023 13:13
@yankinmax
Copy link
Contributor Author

Tests are failing because of other modules. I wonder what I can do here more. Locally tests run without errors

@pedrobaeza
Copy link
Member

The problem I'm seeing is that your module affects other module tests:

https:/OCA/server-tools/actions/runs/4134604852/jobs/7145942706#step:8:1111

so you should care about that. Testing locally is isolated. Here, you have some kind on "integration tests".

@gurneyalex
Copy link
Member

https:/yankinmax/server-tools/pull/1/files might fix the CI

@paulius-sladkevicius
Copy link

@hbrunn all is green, can you merge it? I would be happy to start the migration to v16.

@yankinmax
Copy link
Contributor Author

@hbrunn all is green, can you merge it? I would be happy to start the migration to v16.

it's module to migrate to v15 not v16. if you need to v16 you should use this one in your project:

@paulius-sladkevicius
Copy link

@hbrunn all is green, can you merge it? I would be happy to start the migration to v16.

it's module to migrate to v15 not v16. if you need to v16 you should use this one in your project:

Thanks for pointing it out, somehow I missed this already existing PR 👍

@gurneyalex
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-2547-by-gurneyalex-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit c4f18ca into OCA:15.0 Mar 23, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 910eaf5. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.