Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[9.0] [MIG] html_image_url_extractor module #624

Merged
merged 2 commits into from
Nov 29, 2016
Merged

[9.0] [MIG] html_image_url_extractor module #624

merged 2 commits into from
Nov 29, 2016

Conversation

cubells
Copy link
Sponsor Member

@cubells cubells commented Nov 28, 2016

  • Updated README.rst

@Tecnativa

yajo and others added 2 commits November 28, 2016 10:51
@yajo @cubells
Image extractor from HTML fields. (OCA#354)
f58523d 
* [8.0][html_image_url_extractor] Image extractor from HTML fields.

This technical utility allows the developer to get a list of image URLs from any piece of HTML.

You can use it for example, to get the cover image from a blog post (upcoming module), or to create a slider with all images from it.
@cubells
[9.0] [MIG] html_image_url_extractor
e707a7d 
 * Updated README.rst
@pedrobaeza pedrobaeza mentioned this pull request Nov 28, 2016
Closed
59 tasks
lasley
lasley reviewed Nov 29, 2016
View reviewed changes
html_image_url_extractor/models/ir_fields_converter.py
:param bool fail:
If ``True``, exceptions will be raised.
"""
# Parse HTML
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parsing HTML with Regex is never really the way to go, please see this famous answer on SO for an amazing elaboration.

Why not just xml.dom.minidom.parseString(html).getElementsByTagName('img') + other logic?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only a migration of something done on v8. As this extract utility is very specific, I wouldn't touch this too much...

Copy link
Contributor

@lasley lasley Nov 29, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But when we bring something into OCA aren't we guaranteeing that it works by OCA standards? This definitely does not work in all instances - I've been burned by this before.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is not working? It's in v8 and used by many modules without problems

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright wait maybe I'm misinterpreting something here. The regex is being applied against an element node, so we're good. My bad I misread there.

lasley
lasley suggested changes Nov 29, 2016
View reviewed changes
Copy link
Contributor

@lasley lasley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cubells but I'm 👎 on this, please see my inline comment regarding the use of Regexes for this purpose.

lasley
lasley approved these changes Nov 29, 2016
View reviewed changes
Copy link
Contributor

@lasley lasley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In light of inline convo, this was a stupid me situation. LGTM! 👍

@lasley lasley added this to the 9.0 milestone Nov 29, 2016
@moylop260 moylop260 merged commit cec41e8 into OCA:9.0 Nov 29, 2016
yajo pushed a commit to Tecnativa/server-tools that referenced this pull request Jun 22, 2017
@cubells @yajo
html_image_url_extractor module (OCA#624)
137bc59 
* Image extractor from HTML fields. (OCA#354)

* [8.0][html_image_url_extractor] Image extractor from HTML fields.

This technical utility allows the developer to get a list of image URLs from any piece of HTML.

You can use it for example, to get the cover image from a blog post (upcoming module), or to create a slider with all images from it.

* [9.0] [MIG] html_image_url_extractor
 * Updated README.rst
yajo pushed a commit to Tecnativa/server-tools that referenced this pull request Jul 17, 2017
@cubells @yajo
html_image_url_extractor module (OCA#624)
951352f 
* Image extractor from HTML fields. (OCA#354)

* [8.0][html_image_url_extractor] Image extractor from HTML fields.

This technical utility allows the developer to get a list of image URLs from any piece of HTML.

You can use it for example, to get the cover image from a blog post (upcoming module), or to create a slider with all images from it.

* [9.0] [MIG] html_image_url_extractor
 * Updated README.rst
tarteo pushed a commit to tarteo/server-tools that referenced this pull request Feb 14, 2018
@cubells @tarteo
html_image_url_extractor module (OCA#624)
16f6add 
* Image extractor from HTML fields. (OCA#354)

* [8.0][html_image_url_extractor] Image extractor from HTML fields.

This technical utility allows the developer to get a list of image URLs from any piece of HTML.

You can use it for example, to get the cover image from a blog post (upcoming module), or to create a slider with all images from it.

* [9.0] [MIG] html_image_url_extractor
 * Updated README.rst
MrFangD pushed a commit to MrFangD/server-tools that referenced this pull request Nov 3, 2018
@cubells @MrFangD
html_image_url_extractor module (OCA#624)
4a89640 
* Image extractor from HTML fields. (OCA#354)

* [8.0][html_image_url_extractor] Image extractor from HTML fields.

This technical utility allows the developer to get a list of image URLs from any piece of HTML.

You can use it for example, to get the cover image from a blog post (upcoming module), or to create a slider with all images from it.

* [9.0] [MIG] html_image_url_extractor
 * Updated README.rst
@yajo yajo deleted the 9.0-mig-html_image_url_extractor branch November 5, 2018 09:01
cristinamartinrod pushed a commit to Tecnativa/server-tools that referenced this pull request Feb 12, 2019
@cubells @cristinamartinrod
html_image_url_extractor module (OCA#624)
bfe3a21 
* Image extractor from HTML fields. (OCA#354)

* [8.0][html_image_url_extractor] Image extractor from HTML fields.

This technical utility allows the developer to get a list of image URLs from any piece of HTML.

You can use it for example, to get the cover image from a blog post (upcoming module), or to create a slider with all images from it.

* [9.0] [MIG] html_image_url_extractor
 * Updated README.rst
tarteo pushed a commit to tarteo/server-tools that referenced this pull request Jan 9, 2020
@cubells @tarteo
html_image_url_extractor module (OCA#624)
8580954 
* Image extractor from HTML fields. (OCA#354)

* [8.0][html_image_url_extractor] Image extractor from HTML fields.

This technical utility allows the developer to get a list of image URLs from any piece of HTML.

You can use it for example, to get the cover image from a blog post (upcoming module), or to create a slider with all images from it.

* [9.0] [MIG] html_image_url_extractor
 * Updated README.rst
victoralmau pushed a commit to Tecnativa/server-tools that referenced this pull request Feb 24, 2021
@cubells @victoralmau
html_image_url_extractor module (OCA#624)
8e0c1e5 
* Image extractor from HTML fields. (OCA#354)

* [8.0][html_image_url_extractor] Image extractor from HTML fields.

This technical utility allows the developer to get a list of image URLs from any piece of HTML.

You can use it for example, to get the cover image from a blog post (upcoming module), or to create a slider with all images from it.

* [9.0] [MIG] html_image_url_extractor
 * Updated README.rst
victoralmau pushed a commit to Tecnativa/server-tools that referenced this pull request Mar 15, 2021
@cubells @victoralmau
html_image_url_extractor module (OCA#624)
1837e21 
* Image extractor from HTML fields. (OCA#354)

* [8.0][html_image_url_extractor] Image extractor from HTML fields.

This technical utility allows the developer to get a list of image URLs from any piece of HTML.

You can use it for example, to get the cover image from a blog post (upcoming module), or to create a slider with all images from it.

* [9.0] [MIG] html_image_url_extractor
 * Updated README.rst
ThomasBinsfeld pushed a commit to acsone/server-tools that referenced this pull request Mar 23, 2021
@cubells @ThomasBinsfeld
html_image_url_extractor module (OCA#624)
be48585 
* Image extractor from HTML fields. (OCA#354)

* [8.0][html_image_url_extractor] Image extractor from HTML fields.

This technical utility allows the developer to get a list of image URLs from any piece of HTML.

You can use it for example, to get the cover image from a blog post (upcoming module), or to create a slider with all images from it.

* [9.0] [MIG] html_image_url_extractor
 * Updated README.rst
hkapatel-initos pushed a commit to initOS/server-tools that referenced this pull request Jul 2, 2021
@cubells @hkapatel-initos
html_image_url_extractor module (OCA#624)
5e5560b 
* Image extractor from HTML fields. (OCA#354)

* [8.0][html_image_url_extractor] Image extractor from HTML fields.

This technical utility allows the developer to get a list of image URLs from any piece of HTML.

You can use it for example, to get the cover image from a blog post (upcoming module), or to create a slider with all images from it.

* [9.0] [MIG] html_image_url_extractor
 * Updated README.rst
mtelahun pushed a commit to mtelahun/server-tools that referenced this pull request Sep 5, 2022
@cubells @mtelahun
html_image_url_extractor module (OCA#624)
34c0d8c 
* Image extractor from HTML fields. (OCA#354)

* [8.0][html_image_url_extractor] Image extractor from HTML fields.

This technical utility allows the developer to get a list of image URLs from any piece of HTML.

You can use it for example, to get the cover image from a blog post (upcoming module), or to create a slider with all images from it.

* [9.0] [MIG] html_image_url_extractor
 * Updated README.rst
victoralmau pushed a commit to Tecnativa/server-tools that referenced this pull request Feb 27, 2023
@cubells @victoralmau
html_image_url_extractor module (OCA#624)
8f88832 
* Image extractor from HTML fields. (OCA#354)

* [8.0][html_image_url_extractor] Image extractor from HTML fields.

This technical utility allows the developer to get a list of image URLs from any piece of HTML.

You can use it for example, to get the cover image from a blog post (upcoming module), or to create a slider with all images from it.

* [9.0] [MIG] html_image_url_extractor
 * Updated README.rst

OCA Transbot updated translations from Transifex
adasatorres pushed a commit to adasatorres/server-tools that referenced this pull request Aug 3, 2023
@cubells
html_image_url_extractor module (OCA#624)
70fbbd3 
* Image extractor from HTML fields. (OCA#354)

* [8.0][html_image_url_extractor] Image extractor from HTML fields.

This technical utility allows the developer to get a list of image URLs from any piece of HTML.

You can use it for example, to get the cover image from a blog post (upcoming module), or to create a slider with all images from it.

* [9.0] [MIG] html_image_url_extractor
 * Updated README.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@lasley lasley lasley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
9.0
Development

Successfully merging this pull request may close these issues.
5 participants
@cubells @pedrobaeza @lasley @moylop260 @yajo