FIX when raven unavailable #881
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 29, 2017
pedrobaeza
reviewed
Jun 29, 2017
| 'requests_threaded': raven.transport.ThreadedRequestsHTTPTransport, | ||
| 'synchronous': raven.transport.HTTPTransport, | ||
| 'threaded': raven.transport.ThreadedHTTPTransport, | ||
| 'requests_synchronous': getattr(raven, 'transport.RequestsHTTPTransport', False), |
There was a problem hiding this comment.
getattr is not recursive AFAIK. Better to move this to try section
There was a problem hiding this comment.
or add raven_import = True in try and False in exception and then add a conditional dict
There was a problem hiding this comment.
Yes, it's another possibility
|
Hi guys, sorry for breaking AFAICT, this will not be enough, as imports from raven are used elsewhere at module level. Had a quick go at it, covering (I hope) all cases where imports from Please let me know if you have better ideas how to solve it (I especially dislike the part of |
|
👍 thanks |
|
Guidelines improvement https:/OCA/maintainer-tools/pull/279/files |
|
Are you going to change this PR according the advise from @naglis? |
|
No @naglis have done this branch 10.0...versada:fix_missing_raven and is nice |
naglis
pushed a commit
to versada/server-tools
that referenced
this pull request
Jun 30, 2017
njeudy
pushed a commit
to njeudy/server-tools
that referenced
this pull request
Oct 23, 2017
tansadio
pushed a commit
to tansadio/server-tools
that referenced
this pull request
Nov 28, 2017
njeudy
pushed a commit
to njeudy/server-tools
that referenced
this pull request
Dec 3, 2017
njeudy
pushed a commit
to njeudy/server-tools
that referenced
this pull request
Dec 19, 2017
njeudy
pushed a commit
to njeudy/server-tools
that referenced
this pull request
Jan 11, 2018
njeudy
pushed a commit
to njeudy/server-tools
that referenced
this pull request
Jan 11, 2018
legalsylvain
pushed a commit
that referenced
this pull request
Nov 17, 2018
Menestrels
pushed a commit
to avoinsystems/server-tools
that referenced
this pull request
Feb 27, 2020
IvanShirokikh
pushed a commit
to IvanShirokikh/server-tools
that referenced
this pull request
Feb 27, 2020
IvanShirokikh
pushed a commit
to IvanShirokikh/server-tools
that referenced
this pull request
Feb 27, 2020
IvanShirokikh
pushed a commit
to IvanShirokikh/server-tools
that referenced
this pull request
Feb 27, 2020
mlaitinen
pushed a commit
to avoinsystems/server-tools
that referenced
this pull request
May 7, 2020
traviswaelbro
pushed a commit
to gobluestingray/server-tools
that referenced
this pull request
Nov 17, 2020
dnplkndll
pushed a commit
to Kencove/server-tools
that referenced
this pull request
Dec 28, 2020
dnplkndll
pushed a commit
to Kencove/server-tools
that referenced
this pull request
Dec 28, 2020
dnplkndll
pushed a commit
to Kencove/server-tools
that referenced
this pull request
Dec 29, 2020
moylop260
pushed a commit
to Vauxoo/server-tools
that referenced
this pull request
Jan 22, 2021
luisg123v
pushed a commit
to vauxoo-dev/server-tools
that referenced
this pull request
Jan 25, 2021
atchuthan
pushed a commit
to Kencove/server-tools
that referenced
this pull request
May 27, 2021
airlessproject
pushed a commit
to airlessproject/server-tools
that referenced
this pull request
Jul 18, 2022
aisopuro
pushed a commit
to avoinsystems/server-tools
that referenced
this pull request
Oct 17, 2022
aisopuro
pushed a commit
to avoinsystems/server-tools
that referenced
this pull request
Oct 20, 2022
SodexisTeam
pushed a commit
to sodexis/server-tools
that referenced
this pull request
Jan 3, 2023
aisopuro
pushed a commit
to avoinsystems/server-tools
that referenced
this pull request
Jan 26, 2024
aisopuro
pushed a commit
to avoinsystems/server-tools
that referenced
this pull request
Feb 5, 2024
aisopuro
pushed a commit
to avoinsystems/server-tools
that referenced
this pull request
May 13, 2024
PieterPaulussen
pushed a commit
to The-O-Team/server-tools
that referenced
this pull request
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not tested but should works
@pedrobaeza @naglis