Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG]stock_no_negative: Migrated to v17 #1437

Merged
merged 60 commits into from
Mar 13, 2024
Merged

[17.0][MIG]stock_no_negative: Migrated to v17 #1437

merged 60 commits into from
Mar 13, 2024

Conversation

fd-oerp
Copy link

@fd-oerp fd-oerp commented Nov 23, 2023

No description provided.

alexis-via and others added 30 commits November 23, 2023 10:32
@alexis-via @fd-oerp
[MIG] stock_no_negative: Migration to 10.0
99a2369
@serpentcs-dev1 @fd-oerp
[ADD] test cases
950ec31
@MiquelRForgeFlow @fd-oerp
[IMP] stock_no_negative: Behave correctly on other tests
56e85b3
@etobella @fd-oerp
[MIG] stock_no_negative: Migration to 11.0
9b11ab6
@rgarnau @fd-oerp
minor fixes
addd67a
@oca-transbot @fd-oerp
OCA Transbot updated translations from Transifex
eee0ae7
@etobella @fd-oerp
[FIX] Issue #391
be6e2a4
@pedrobaeza @fd-oerp
[FIX] stock_no_negative: Incorrect tests
3bb19e5
@oca-transbot @fd-oerp
OCA Transbot updated translations from Transifex
3e13299
@oca-travis @fd-oerp
[UPD] Update stock_no_negative.pot
1637226
@osoul @fd-oerp
Added translation using Weblate (Arabic)
a4283b1
@osoul @fd-oerp
Translated using Weblate (Arabic)
200b075 
Currently translated at 50.0% (4 of 8 strings)

Translation: stock-logistics-workflow-11.0/stock-logistics-workflow-11.0-stock_no_negative
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-11-0/stock-logistics-workflow-11-0-stock_no_negative/ar/
@pedrobaeza @fd-oerp
[IMP] stock_no_negative: Avoid problems on integration tests
6725faa 
For example, when you install *delivery* along with this one
@JordiBForgeFlow @fd-oerp
[stock_no_negative][IMP] Add the ability to allow negative stock for …
0283237 
…individual

stock locations.
@OCA-git-bot @fd-oerp
[UPD] README.rst
d1b3dba
@oca-travis @fd-oerp
[UPD] Update stock_no_negative.pot
aa80ccd
@oca-transbot @fd-oerp
Update translation files
e4f6909 
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
@JordiBForgeFlow @fd-oerp
fix in incorrect view
dd5575a
@meigallodixital @fd-oerp
[MIG] stock_no_negative: Migration to 12.0
7ddd774
@oca-travis @fd-oerp
[UPD] Update stock_no_negative.pot
a2d400d
@oca-transbot @fd-oerp
Update translation files
50f92af 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-workflow-12.0/stock-logistics-workflow-12.0-stock_no_negative
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-12-0/stock-logistics-workflow-12-0-stock_no_negative/
@OCA-git-bot @fd-oerp
[ADD] icon.png
a2e9357
@OCA-git-bot @fd-oerp
[UPD] README.rst
ba3769c
@qdelcourte @fd-oerp
[IMP] stock_no_negative: black, isort
09a9492
@qdelcourte @fd-oerp
[MIG] stock_no_negative: Migration to 13.0
4585f39
@qdelcourte @fd-oerp
[UPD] CONTRIBUTORS.rst and HISTORY.rst
ba74008
@oca-travis @fd-oerp
[UPD] Update stock_no_negative.pot
c229ab9
@OCA-git-bot @fd-oerp
[UPD] README.rst
f2dbbf8
@oca-transbot @fd-oerp
Update translation files
4f8f48a 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-workflow-13.0/stock-logistics-workflow-13.0-stock_no_negative
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-13-0/stock-logistics-workflow-13-0-stock_no_negative/
@MiquelRForgeFlow @fd-oerp
[UPD] Eficent -> ForgeFlow
39c94d0
smcqueen81
smcqueen81 approved these changes Dec 14, 2023
View reviewed changes
Copy link

@smcqueen81 smcqueen81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funcional OK

@fd-oerp
Copy link
Author

fd-oerp commented Dec 20, 2023

Hi @rousseldenis is there anything I need to do from my side in this PR ?

rousseldenis
rousseldenis requested changes Dec 21, 2023
View reviewed changes
Copy link
Sponsor Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above

@fd-oerp
Copy link
Author

fd-oerp commented Jan 9, 2024

See above

Hi @rousseldenis , any comments from your side regarding this ?

@yay-sw
Copy link

yay-sw commented Feb 17, 2024

Hi @rousseldenis , any updates regarding this?

@fd-oerp
Copy link
Author

fd-oerp commented Feb 29, 2024

Hi @celm1990 @rousseldenis any update on this PR, anything needs to be updated from my side?

@celm1990
Copy link
Sponsor Contributor

celm1990 commented Mar 3, 2024 •
edited
Loading

@fd-oerp
Please split your commit according guideslines https:/OCA/maintainer-tools/wiki/Migration-to-version-17.0
image

A first commit only wit pre-commit run, and second commit with all changes related to migration
image

@fd-oerp
Copy link
Author

fd-oerp commented Mar 4, 2024

@fd-oerp Please split your commit according guideslines https:/OCA/maintainer-tools/wiki/Migration-to-version-17.0 image

A first commit only wit pre-commit run, and second commit with all changes related to migration image

Hi @celm1990 splitted the commits as per the guidelines(precommit + mig), you can review and proceed, please.

john-herholz-dt
john-herholz-dt approved these changes Mar 6, 2024
View reviewed changes
Copy link

@john-herholz-dt john-herholz-dt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional check, works as expected.

celm1990
celm1990 approved these changes Mar 6, 2024
View reviewed changes
Copy link
Sponsor Contributor

@celm1990 celm1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fd-oerp please adapt your commit message
image

@fd-oerp
Copy link
Author

fd-oerp commented Mar 6, 2024

LGTM

@fd-oerp please adapt your commit message image

Hi @celm1990 , should I modify messages to just like 'migrated module..' or something?
because these messages indicate what I have done, please lead me.

@fd-oerp
Copy link
Author

fd-oerp commented Mar 6, 2024

LGTM
@fd-oerp please adapt your commit message image

Hi @celm1990 , should I modify messages to just like 'migrated module..' or something? because these messages indicate what I have done, please lead me.

@celm1990 , or would it be fine if I delete all those commits (MIG once) and just do one commit for MIG ?

@fd-oerp
Copy link
Author

fd-oerp commented Mar 6, 2024

Hi @celm1990 , I updated the migrated module with just one MIG commit. please review!

@fd-oerp
[17.0][MIG]stock_no_negative: Migrated module to v17.0
281550e 
[17.0][MIG]stock_no_negative: Migrated module to v17.0

[17.0][MIG]stock_no_negative: Migrated module to v17.0
@fd-oerp
Copy link
Author

fd-oerp commented Mar 8, 2024

Hi @rousseldenis , could you please review this and proceed ?

@fd-oerp
Copy link
Author

fd-oerp commented Mar 12, 2024

Hi @rousseldenis , Could you please review this and let me know if any changes are needed or proceed?

@celm1990
Copy link
Sponsor Contributor

@OCA/logistics-maintainers could somebody help me with revision and merge please?

rousseldenis
rousseldenis approved these changes Mar 13, 2024
View reviewed changes
Copy link
Sponsor Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

@rousseldenis
Copy link
Sponsor Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-1437-by-rousseldenis-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit ba2eada into OCA:17.0 Mar 13, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 6caca90. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@celm1990 celm1990 celm1990 approved these changes

@rousseldenis rousseldenis rousseldenis approved these changes

@smcqueen81 smcqueen81 smcqueen81 approved these changes

@john-herholz-dt john-herholz-dt john-herholz-dt approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 migration needs review
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.