Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add endpoint DELETE /kill_mets_server_zombies to kill -SIGTERM METS servers with ctime > 60mins ago #1283

Merged
merged 8 commits into from
Oct 2, 2024
Merged

add endpoint DELETE /kill_mets_server_zombies to kill -SIGTERM METS servers with ctime > 60mins ago #1283

merged 8 commits into from
Oct 2, 2024

Conversation

kba
Copy link
Member

@kba kba commented Oct 2, 2024

Also, use os.kill directly in OcrdMetsServer.kill_process (no idea why I did that via subprocess.run 🤷)

@kba kba requested a review from MehmedGIT October 2, 2024 12:09
MehmedGIT
MehmedGIT requested changes Oct 2, 2024
View reviewed changes
src/ocrd/mets_server.py Outdated Show resolved Hide resolved
@kba kba marked this pull request as ready for review October 2, 2024 12:49
MehmedGIT
MehmedGIT requested changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@MehmedGIT MehmedGIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what I meant, at least just inside the OcrdMetsServer.kill_process(). I don't mind what exactly happens inside the workaround endpoint.

src/ocrd/mets_server.py Outdated Show resolved Hide resolved
@MehmedGIT MehmedGIT self-requested a review October 2, 2024 13:08
@kba kba changed the title add endpoint DELETE /workflow/kill-mets-server-zombies to kill -SIGTERM METS servers with ctime > 60mins ago add endpoint DELETE /kill_mets_server_zombies to kill -SIGTERM METS servers with ctime > 60mins ago Oct 2, 2024
@kba kba merged commit c5fd843 into network_client_block_prints Oct 2, 2024
1 check passed
@kba kba deleted the mets-server-kill-zombies branch October 2, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MehmedGIT MehmedGIT MehmedGIT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kba @MehmedGIT