Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocrd.processor.base: add property zip_input_files #635

Merged
merged 10 commits into from
Nov 3, 2020
Merged

ocrd.processor.base: add property zip_input_files #635

merged 10 commits into from
Nov 3, 2020

Commits on Oct 23, 2020

  1. ocrd.processor.base: add property zip_input_files

    @bertsky
    bertsky committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    4d5888a View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2020

  1. Processor.zip_input_files must be method not property

    @kba
    kba committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    20f9f6b View commit details
    Browse the repository at this point in the history

  2. test Processor.zip_input_files

    @kba
    kba committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    5f6b5af View commit details
    Browse the repository at this point in the history

  3. Processor.zip_input_files: allow overriding mimetype

    @kba
    kba committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    102fd2d View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2020

  1. processor.zip_input_files: PAGE/image-fallback and multi-match error … 

    …handling…

- allow different kinds of error handling
  for the multi-match case (single page,
  multiple files): `on_error`
  - `skip`: None
  - `first`: first match
  - `last`: last match
  - `abort`: raise an exception
- if `mimetype` is inactive, support default OCR-D
  PAGE-image fallback semantics;
  - if no PAGE but multiple other files,
    then delegate to general error handling above
  - if multiple PAGE files, then raise an exception
    @bertsky
    bertsky committed Nov 2, 2020
    Configuration menu
    Copy the full SHA
    397d1b6 View commit details
    Browse the repository at this point in the history

  2. extend tests for processor.zip_input_files

    @bertsky
    bertsky committed Nov 2, 2020
    Configuration menu
    Copy the full SHA
    0349674 View commit details
    Browse the repository at this point in the history

  3. Workspace.resolve_image_{exif,as_pil}: properly raise on empty file path

    @bertsky
    bertsky committed Nov 2, 2020
    Configuration menu
    Copy the full SHA
    a560c69 View commit details
    Browse the repository at this point in the history

  4. test Processor.zip_input_files with run-time page_id selection, too

    @bertsky
    bertsky committed Nov 2, 2020
    Configuration menu
    Copy the full SHA
    ddaa28a View commit details
    Browse the repository at this point in the history

  5. 🔥 Processor.{zip_,}input_files: require input_file_grp 

    (raise an exception if no input fileGrp was set)
    @bertsky
    bertsky committed Nov 2, 2020
    Configuration menu
    Copy the full SHA
    8f8cbb9 View commit details
    Browse the repository at this point in the history

  6. adapt/extend tests for Processor.input_files (empty input_file_grp)

    @bertsky
    bertsky committed Nov 2, 2020
    Configuration menu
    Copy the full SHA
    625547c View commit details
    Browse the repository at this point in the history