Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests take a long time #1083

Open
schuemie opened this issue Oct 12, 2023 · 3 comments
Open

Unit tests take a long time #1083

schuemie opened this issue Oct 12, 2023 · 3 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@schuemie
Copy link
Member

Do we really need to call executeDiagnostics() 4 times on 12 cohorts on each database platform? I would think calling 2 times (once to test iterative running) on 2 cohorts should be enough.

CohortDiagnostics is currently a bottleneck in creating a HADES-wide release, as its unit tests do not appear to complete ever on my machine.

@azimov azimov added help wanted Extra attention is needed good first issue Good for newcomers labels Oct 21, 2023
@azimov
Copy link
Collaborator

azimov commented Oct 21, 2023

This is highly desirable but a large amount of work and suitable to pick up for a few developers interested in learning this package.

Ideally, we should test the functions of this package individually with isolated tests. At some point testing the entire pacakge was decided (probably to get unit test counts up).

@azimov
Copy link
Collaborator

azimov commented Oct 21, 2023

Goal - have all unit tests to run in under 10 minutes

@azimov
Copy link
Collaborator

azimov commented Nov 16, 2023

The unit tests have been greatly sped up on database platforms by sampling cohorts, however, this will require a release of CohortGenerator first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants