-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit tests take a long time #1083
Comments
This is highly desirable but a large amount of work and suitable to pick up for a few developers interested in learning this package. Ideally, we should test the functions of this package individually with isolated tests. At some point testing the entire pacakge was decided (probably to get unit test counts up). |
Goal - have all unit tests to run in under 10 minutes |
The unit tests have been greatly sped up on database platforms by sampling cohorts, however, this will require a release of CohortGenerator first |
Do we really need to call
executeDiagnostics()
4 times on 12 cohorts on each database platform? I would think calling 2 times (once to test iterative running) on 2 cohorts should be enough.CohortDiagnostics is currently a bottleneck in creating a HADES-wide release, as its unit tests do not appear to complete ever on my machine.
The text was updated successfully, but these errors were encountered: