Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing columns from CDM_SOURCE and using METADATA instead #166

Closed
vojtechhuser opened this issue Mar 2, 2018 · 4 comments
Closed

Removing columns from CDM_SOURCE and using METADATA instead #166

vojtechhuser opened this issue Mar 2, 2018 · 4 comments
Assignees
Labels

Comments

@vojtechhuser
Copy link
Collaborator

vojtechhuser commented Mar 2, 2018

New convention for METADATA table:

  • record CDM version in METADATA table with METADATA.VALUE = 'CDM version' and METADATA.VALUE_AS_STRING = '5.3' (or other formal version of CDM)
    The table must contain exactly one row for 'CDM version'

Changes to existing tables:

  • delete column CDM_VERSION from table CDM_SOURCE

This is because the CDM_SOURCE can have 2 or more rows and the version may differ.

@vojtechhuser
Copy link
Collaborator Author

The first post will be addited as Themis WG1 finalizes the discussion. WG1 adopted the issue on my proposal to come up with convenstions for CDM source.

relevant forum disucssion is here:
http://forums.ohdsi.org/t/cdm-source-table-usage-and-conventions/4015

@clairblacketer
Copy link
Contributor

I like this idea, I also think it should be mandatory to save this value for every CDM instance

@clairblacketer
Copy link
Contributor

I have added this convention to v6.0 with a slight modification. Since we have not agreed in the CDM wg to remove the 'cdm_version' field from the CDM_SOURCE table, I have not removed it from the DDL. I did, however, add a line that will automatically add the CDM version to the metadata table.

This was referenced Oct 11, 2018
@clairblacketer
Copy link
Contributor

added in v6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants